Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awslint:props-no-arn-refs #2436

Closed
eladb opened this issue May 1, 2019 · 0 comments · Fixed by #2539
Closed

awslint:props-no-arn-refs #2436

eladb opened this issue May 1, 2019 · 0 comments · Fixed by #2539
Labels
package/awscl Cross-cutting issues related to the AWS Construct Library

Comments

@eladb
Copy link
Contributor

eladb commented May 1, 2019 •
edited
Loading

Props should use strong types instead of attributres (forbid props with "arn" suffix)
@eladb eladb added the package/awscl Cross-cutting issues related to the AWS Construct Library label May 1, 2019
@eladb eladb changed the title awslint:props-no-arn-refs: Props should use strong types instead of attributres (forbid props with "arn" suffix) awslint:props-no-arn-refs May 1, 2019
@shivlaks shivlaks self-assigned this May 7, 2019
shivlaks added a commit that referenced this issue May 13, 2019
@shivlaks
refactor: L2 constructs should use strong types instead of attributes…
c4a1055 
…. props should not have "arn" suffix (awslint:props-no-arn-refs)

Adds a new awslint:props-no-arn-refs rule which valides that props do not have an "arn" suffix.
Props should use strong types instead of attributes.

This is in accordance with the new AWS Construct Library guidelines.

Fixes #2436
@shivlaks shivlaks mentioned this issue May 13, 2019
Merged
4 tasks
shivlaks added a commit that referenced this issue May 14, 2019
@shivlaks
refactor: L2 constructs should use strong types instead of attributes…
8e3c4ca 
…. props should not have "arn" suffix (awslint:props-no-arn-refs) (#2539)

* refactor: L2 constructs should use strong types instead of attributes. props should not have "arn" suffix (awslint:props-no-arn-refs)

Adds a new awslint:props-no-arn-refs rule which valides that props do not have an "arn" suffix.
Props should use strong types instead of attributes.

This is in accordance with the new AWS Construct Library guidelines.

Fixes #2436

* excluding  CrossAccountDestination construct which supports CloudWatchLogs to Kinesis streams in a different destination account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package/awscl Cross-cutting issues related to the AWS Construct Library
Projects
None yet
Milestone
No milestone
2 participants
@eladb @shivlaks