Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the tests are being skipped in the repository #25137

Closed
vinayak-kukreja opened this issue Apr 14, 2023 · 1 comment · Fixed by #26367
Closed

Some of the tests are being skipped in the repository #25137

vinayak-kukreja opened this issue Apr 14, 2023 · 1 comment · Fixed by #26367
Assignees
@mrgrain
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1

Comments

@vinayak-kukreja
Copy link
Contributor

vinayak-kukreja commented Apr 14, 2023 •
edited
Loading

Currently in the repository, there are some tests that are being skipped with test.skip. Some of these tests were disabled during repository restructure due intermittent failures.

These tests should be re-enabled and fixed. Ideally there should be no skipped tests in the repository.
@vinayak-kukreja vinayak-kukreja added p1 effort/medium Medium work item – several days of effort labels Apr 14, 2023
@peterwoodworth peterwoodworth added the bug This issue is a bug. label May 1, 2023
@vinayak-kukreja vinayak-kukreja self-assigned this May 25, 2023
@vinayak-kukreja vinayak-kukreja mentioned this issue Jun 5, 2023
Closed
@vinayak-kukreja vinayak-kukreja removed their assignment Jul 3, 2023
@mrgrain mrgrain self-assigned this Jul 14, 2023
@mrgrain mrgrain mentioned this issue Jul 14, 2023
Merged
@mergify mergify bot closed this as completed in #26367 Jul 16, 2023
mergify bot pushed a commit that referenced this issue Jul 16, 2023
@mrgrain
chore(cdk-lib): re-enable skipped tests (#26367)
99fd917 
Some tests were previously skipped. Un-skip them and put a linter rule in place that prevents this.

Closes #25137 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

colifran pushed a commit that referenced this issue Jul 17, 2023
@mrgrain @colifran
chore(cdk-lib): re-enable skipped tests (#26367)
761cf40 
Some tests were previously skipped. Un-skip them and put a linter rule in place that prevents this.

Closes #25137 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
@mrgrain @bmoffatt
chore(cdk-lib): re-enable skipped tests (aws#26367)
e0f36ad 
Some tests were previously skipped. Un-skip them and put a linter rule in place that prevents this.

Closes aws#25137 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrgrain mrgrain

Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cdk-lib): re-enable skipped tests aws/aws-cdk
3 participants
@mrgrain @peterwoodworth @vinayak-kukreja