Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-events): Validate events rule name #25352

Closed
1 of 2 tasks
pyto86pri opened this issue Apr 28, 2023 · 2 comments · Fixed by #25366
Closed
1 of 2 tasks

(aws-events): Validate events rule name #25352

pyto86pri opened this issue Apr 28, 2023 · 2 comments · Fixed by #25366
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@pyto86pri
Copy link
Contributor

pyto86pri commented Apr 28, 2023 •
edited
Loading

Describe the feature

The events rule name should be validated. Currently, event rule names are limited in the number of characters and characters that can be used.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-events-rule.html#cfn-events-rule-name

Use Case

Notice bugs without deploying. It's useful for validation in CI or other.

Proposed Solution

Add rule name validation in Rule class.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.77.0

Environment details (OS name and version, etc.)

MacOS
@pyto86pri pyto86pri added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 28, 2023
@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label Apr 28, 2023
@pahud
Copy link
Contributor

pahud commented Apr 28, 2023

Thank you for your report and PR!

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 28, 2023
@pyto86pri pyto86pri mentioned this issue Apr 28, 2023
Merged
@mergify mergify bot closed this as completed in #25366 May 1, 2023
mergify bot pushed a commit that referenced this issue May 1, 2023
@pyto86pri
feat(events): Validate events rule name (#25366)
5bdb012 
This PR is adding validations for events rule name.

Closes #25352.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented May 1, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(events): Validate events rule name pyto86pri/aws-cdk
2 participants
@pahud @pyto86pri