Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"FAILED, No updates are to be performed" when adding a "Transform" to a stack #2553

Closed
danlaramay opened this issue May 15, 2019 · 8 comments
Closed

"FAILED, No updates are to be performed" when adding a "Transform" to a stack #2553

danlaramay opened this issue May 15, 2019 · 8 comments
Assignees
@eladb
Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. p2

Comments

@danlaramay
Copy link

danlaramay commented May 15, 2019 •
edited by NGL321
Loading

Describe the bug
When using templateOptions.transform on a stack the below error will appear on any stack that has no updates.

 ❌  cdk-app failed: Error: Failed to create ChangeSet CDK-2372b61b-68c3-4cad-a447-9e5f78c8fe11 on cdk-app: FAILED, No updates are to be performed.
Failed to create ChangeSet CDK-2372b61b-68c3-4cad-a447-9e5f78c8fe11 on cdk-app: FAILED, No updates are to be performed.
Error: Failed to create ChangeSet CDK-2372b61b-68c3-4cad-a447-9e5f78c8fe11 on cdk-app: FAILED, No updates are to be performed.
    at waitFor (/tmp/.nvm/versions/node/v11.10.1/lib/node_modules/cdk/node_modules/aws-cdk/lib/api/util/cloudformation.ts:115:11)
    at processTicksAndRejections (internal/process/next_tick.js:81:5)

To Reproduce
$ cdk deploy

Expected behavior
If no changes are generated just move on to the next stack.

Version:

  • OS: macOS 10.14.4
  • Programming Language: Typescript
  • CDK Version: 0.31.0
@danlaramay danlaramay added the bug This issue is a bug. label May 15, 2019
@RomainMuller
Copy link
Contributor

Hey @dplbd,

I think the issue is pretty clear here - however it may help getting to a closure faster if you could provide a minimal repro example for your problem.

Regards,
Romain.

@NGL321 NGL321 added @aws-cdk/core Related to core CDK functionality response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Aug 27, 2019
@SomayaB
Copy link
Contributor

SomayaB commented Sep 30, 2019

Hi @dplbd, there hasn't been activity on this issue in a while, are you still experiencing this issue?

@SomayaB SomayaB assigned SomayaB and unassigned RomainMuller Sep 30, 2019
@SomayaB SomayaB added closing-soon This issue will automatically close in 4 days unless further comments are made. and removed response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Oct 1, 2019
@NGL321 NGL321 removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Oct 4, 2019
@NGL321
Copy link
Contributor

NGL321 commented Oct 4, 2019

I am closing out the issue for now due to lack of activity. Please feel free to comment or reopen it if you are still experiencing the bug.

😸

@NGL321 NGL321 closed this as completed Oct 4, 2019
@mpvosseller
Copy link
Contributor

Hi. I am experiencing this issue as well. Can you please re-open. I put together a sample project to demonstrate the issue here: https://github.com/mpvosseller/aws-cdk-issue-2553
Thanks.

@SomayaB SomayaB reopened this Feb 10, 2020
@SomayaB SomayaB assigned eladb and unassigned SomayaB Feb 10, 2020
@eladb eladb added the p2 label Feb 11, 2020
@eladb eladb mentioned this issue Feb 11, 2020
Closed
2 tasks
eladb pushed a commit that referenced this issue Feb 18, 2020
feat(cli): skip deployment if template did not change
50a585d 
Bail-out before executing and creating change sets when the currently deployed template is identical to the one we are about to deploy.

This resolves #6046, where a stack that contains nested stack(s) will always try to update since CloudFormation assumes the nested template might have changed. In the CDK, since nested template URLs are immutable, we can trust that the URL will be changed, and therefore invalidate the *parent* template.

This also fixes the bug described in #2553, where a stack that includes a `Transform` always fail to deploy with `No updates are to be performed` when there are no changes to it.

The switch `--force` can be used to override this behavior.

Added unit test and performed a few manual tests to verify both bugs are resolved.

Resolves #6216
@eladb eladb mentioned this issue Feb 18, 2020
Merged
mergify bot added a commit that referenced this issue Feb 19, 2020
@mergify
feat(cli): faster "no-op" deployments (#6346)
d4a132b 
* feat(cli): skip deployment if template did not change

Bail-out before executing and creating change sets when the currently deployed template is identical to the one we are about to deploy.

This resolves #6046, where a stack that contains nested stack(s) will always try to update since CloudFormation assumes the nested template might have changed. In the CDK, since nested template URLs are immutable, we can trust that the URL will be changed, and therefore invalidate the *parent* template.

This also fixes the bug described in #2553, where a stack that includes a `Transform` always fail to deploy with `No updates are to be performed` when there are no changes to it.

The switch `--force` can be used to override this behavior.

Added unit test and performed a few manual tests to verify both bugs are resolved.

Resolves #6216

* Add alias -f for —force

* Add integration test

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@natCyberark
Copy link

Hi ! We are using latest 1.32.2 version and still experience this issue with cdk deploy. Have no nested stacks.
May be some flag like --no-fail-on-empty-changeset of cloudformation deploy could be added ?
Thank you

@eladb
Copy link
Contributor

eladb commented Apr 16, 2020

@natCyberark can you provide some more details about your use case? Are you trying to add a "transform" to your stack (because this is what this bug is about, albeit title might be misleading).

@eladb eladb changed the title FAILED, No updates are to be performed. "FAILED, No updates are to be performed" when adding a "Transform" to a stack Apr 16, 2020
@eladb eladb closed this as completed Apr 16, 2020
@eladb
Copy link
Contributor

eladb commented Apr 16, 2020

I am closing this one because the transform issue should be resolved already (fixed by #6346) but if @natCyberark you have a different use case that this occurs, please create a new issue with the details.

@natCyberark
Copy link

I run

  1. pip3 install --upgrade --user awscli
  2. npm -g update aws-cdk and
    and it fixed the issue.
    You can close, thank you very much !

@victorholban victorholban mentioned this issue Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@RomainMuller @mpvosseller @eladb @danlaramay @NGL321 @SomayaB @natCyberark