-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-cdk): (enable text output in jest coverage reporters) #26078
Labels
@aws-cdk/aws-config
Related to AWS Config
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Comments
mrpackethead
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Jun 22, 2023
Yeah having a text output would be great! |
pahud
added
p2
effort/medium
Medium work item – several days of effort
effort/small
Small work item – less than a day of effort
and removed
effort/medium
Medium work item – several days of effort
needs-triage
This issue or PR still needs to be triaged.
labels
Jun 22, 2023
@pahud , i could raise a PR for this, its a trivia should we do that? |
This was referenced Jul 26, 2023
We should definitely do this! |
mergify bot
pushed a commit
that referenced
this issue
Aug 25, 2023
For people working over SSH, that can't comfortably look at `coverage/index.html`, generate `coverage/coverage.txt` instead. Closes #26078 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-config
Related to AWS Config
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Describe the feature
A very small change here, to turn on text output for jest testing. Being able to get something that looks like the output below would be very helpful. The coverage reports are avaialble as html in other folders, but this gives the information very concisely where it is needed.
I do not think this would break anything. I've had it turned on for my work on the L2 Construct for lattice and i get clean builds both for my package and the bigger library.
in tools/@aws-cdk/cdk-build-tools/config/jest.config.js line 16-20, add 'text' to the arrary
coverageReporters: [
"lcov",
"html",
"text-summary",
"text",
],
Use Case
Its painful to have to open the html files, particually when i dont' ahve a browser easily avaiable
Proposed Solution
Add 'text' to the coverageReporters
Other Information
No response
Acknowledgements
CDK version used
2.85.0
Environment details (OS name and version, etc.)
N/A
The text was updated successfully, but these errors were encountered: