(app-mesh): WeightedTarget construct is missing port property

[neovasili]

Describe the bug

While the CfnRoute give us the ability to define a route with weighted targets with a port, the L2 construct WeightedTarget does not have that property (only have virtual_node and weight), leveraging us to use L1 constructs instead if we want to use the port specification.

Port is required for routes to nodes that have multiple listeners.

Expected Behavior

WeightedTarget L2 construct also let us specify the port option.

Current Behavior

WeightedTarget L2 construct does not have the property port.

Reproduction Steps

Example in python; the following is not valid code:

appmesh.RouteSpec.grpc(
    weighted_targets=[appmesh.WeightedTarget(virtual_node=node, port=myPortNumber)],
    match=appmesh.GrpcRouteMatch(port=myPortNumber),
)

We need to use L1 construct, to get the same result:

appmesh.CfnRoute.RouteSpecProperty(
    grpc_route=appmesh.CfnRoute.GrpcRouteProperty(
        action=appmesh.CfnRoute.GrpcRouteActionProperty(
            weighted_targets=[appmesh.CfnRoute.WeightedTargetProperty(
                virtual_node=node.virtual_node_name,
                weight=1,
                port=myPortNumber,
            )],
        ),
        match=appmesh.CfnRoute.GrpcRouteMatchProperty(port=myPortNumber),
    ),
)

Possible Solution

Add the Port property to the construct interface, since is already a property in the CloudFormation specs.

Additional Information/Context

No response

CDK CLI Version

2.85.0

Framework Version

2.85.0

Node.js Version

v16.14.2

OS

MacOs Ventura

Language

Python

Language Version

python 3.11.1

Other information

I have checked through the CDK docs that typescript CDK version have the same issue, so I guess this applies to all languages available.

I can work in a fix if there is no reason to not work on this fix.

[pahud]

Yes we should add the port property here

aws-cdk/packages/aws-cdk-lib/aws-appmesh/lib/route-spec.ts

Lines 15 to 27 in a79794e

	export interface WeightedTarget {
	/**
	* The VirtualNode the route points to
	*/
	readonly virtualNode: IVirtualNode;
	/**
	* The weight for the target
	*
	* @default 1
	*/
	readonly weight?: number;
	}

And probably modify here as well

aws-cdk/packages/aws-cdk-lib/aws-appmesh/lib/route-spec.ts

Lines 600 to 609 in a79794e

	function renderWeightedTargets(weightedTargets: WeightedTarget[]): CfnRoute.WeightedTargetProperty[] {
	const renderedTargets: CfnRoute.WeightedTargetProperty[] = [];
	for (const t of weightedTargets) {
	renderedTargets.push({
	virtualNode: t.virtualNode.virtualNodeName,
	weight: t.weight == undefined ? 1 : t.weight,
	});
	}
	return renderedTargets;
	}

[neovasili]

Thanks @pahud!

Already created a PR with the required changes, hope this fits you well 😄

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.