Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app-mesh): support port property on weighted targets #26114

Merged
merged 7 commits into from
Jul 7, 2023
Merged

feat(app-mesh): support port property on weighted targets #26114

merged 7 commits into from
Jul 7, 2023

Conversation

neovasili
Copy link
Contributor

As described in the related issue, WeightedTarget L2 construct was missing port property which is already present in the L1 construct CfnRoute.

This PR adds the missing port property to WeightedTarget L2 construct.

The PR includes unit tests expansion to cover this new property appearance or absence.

Closes #26083.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 26, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 26, 2023 12:48
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 26, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@neovasili neovasili changed the title Fix/app mesh missing port property weighted targets fix(app-mesh): Missing port property weighted targets Jun 26, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 26, 2023 13:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2023
@mrgrain mrgrain changed the title fix(app-mesh): Missing port property weighted targets fix(app-mesh): support port property on weighted targets Jul 5, 2023
@mrgrain mrgrain changed the title fix(app-mesh): support port property on weighted targets feat(app-mesh): support port property on weighted targets Jul 5, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 5, 2023
@mrgrain mrgrain added the pr-linter/exempt-readme The PR linter will not require README changes label Jul 5, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 5, 2023 14:32

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 5, 2023
mrgrain
mrgrain approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f8ac9f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 54f91c8 into aws:main Jul 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

tmokmss pushed a commit to tmokmss/aws-cdk that referenced this pull request Jul 9, 2023
@neovasili @tmokmss
feat(app-mesh): support port property on weighted targets (aws#26114)
17534b3 
As described in the related issue, `WeightedTarget` L2 construct was missing `port` property which is already present in the L1 construct `CfnRoute`.

This PR adds the missing `port` property to `WeightedTarget` L2 construct.

The PR includes unit tests expansion to cover this new property appearance or absence.

Closes aws#26083.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@neovasili @bmoffatt
feat(app-mesh): support port property on weighted targets (aws#26114)
0b4497f 
As described in the related issue, `WeightedTarget` L2 construct was missing `port` property which is already present in the L1 construct `CfnRoute`.

This PR adds the missing `port` property to `WeightedTarget` L2 construct.

The PR includes unit tests expansion to cover this new property appearance or absence.

Closes aws#26083.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(app-mesh): WeightedTarget construct is missing port property
3 participants
@neovasili @aws-cdk-automation @mrgrain