-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-apprunner-alpha): serviceName property being ignored #26237
Labels
@aws-cdk/aws-apprunner
Related to the apprunner package
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
good first issue
Related to contributions. See CONTRIBUTING.md
p2
Comments
roketworks
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 5, 2023
github-actions
bot
added
the
@aws-cdk/aws-apprunner
Related to the apprunner package
label
Jul 5, 2023
#23351 (comment) - issue referenced here |
peterwoodworth
added
good first issue
Related to contributions. See CONTRIBUTING.md
p2
effort/small
Small work item – less than a day of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 5, 2023
Would be an easy fix, feel free to submit a PR |
PR opened here #26238 |
mergify bot
pushed a commit
that referenced
this issue
Jul 7, 2023
Use `serviceName` property when creating CfnService resource. BREAKING CHANGE: This change will be destructive if the `serviceName` is set on an existing resources. Closes #26237 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
tmokmss
pushed a commit
to tmokmss/aws-cdk
that referenced
this issue
Jul 9, 2023
Use `serviceName` property when creating CfnService resource. BREAKING CHANGE: This change will be destructive if the `serviceName` is set on an existing resources. Closes aws#26237 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt
pushed a commit
to bmoffatt/aws-cdk
that referenced
this issue
Jul 29, 2023
Use `serviceName` property when creating CfnService resource. BREAKING CHANGE: This change will be destructive if the `serviceName` is set on an existing resources. Closes aws#26237 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-apprunner
Related to the apprunner package
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
good first issue
Related to contributions. See CONTRIBUTING.md
p2
Describe the bug
When creating an AppRunner service using the
Service
construct theserviceName
property is ignored and a generated service name is used.Expected Behavior
The
serviceName
property gets populated into the Cfn resource in the templateCurrent Behavior
The CloudFormation templated generated by
cdk synth
is missing theserviceName
property.Reproduction Steps
Possible Solution
aws-cdk/packages/@aws-cdk/aws-apprunner-alpha/lib/service.ts
Line 1075 in 41cb288
The property is not used as an input into the L1 construct
Additional Information/Context
No response
CDK CLI Version
2.86.0
Framework Version
2.86.
Node.js Version
19
OS
MacOS
Language
Typescript
Language Version
No response
Other information
#23351 (comment) - referenced in this issue
The text was updated successfully, but these errors were encountered: