Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-apprunner-alpha): serviceName property being ignored #26237

Closed
roketworks opened this issue Jul 5, 2023 · 4 comments · Fixed by #26238
Closed

(aws-apprunner-alpha): serviceName property being ignored #26237

roketworks opened this issue Jul 5, 2023 · 4 comments · Fixed by #26238
Labels
@aws-cdk/aws-apprunner Related to the apprunner package bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@roketworks
Copy link
Contributor

roketworks commented Jul 5, 2023

Describe the bug

When creating an AppRunner service using the Service construct the serviceName property is ignored and a generated service name is used.

Expected Behavior

The serviceName property gets populated into the Cfn resource in the template

Current Behavior

The CloudFormation templated generated by cdk synth is missing the serviceName property.

Reproduction Steps

const repo = ecr.Repository.fromRepositoryName(this, 'repo', 'app')

new apprunner.Service(this, 'Service', {
    serviceName: 'app',
    cpu: apprunner.Cpu.QUARTER_VCPU,
    memory: apprunner.Memory.HALF_GB,
    source: apprunner.Source.fromEcr({
      repository: repo,
      imageConfiguration: { port: 80 },
    })
  })

Possible Solution

const resource = new CfnService(this, 'Resource', {

The property is not used as an input into the L1 construct

Additional Information/Context

No response

CDK CLI Version

2.86.0

Framework Version

2.86.

Node.js Version

19

OS

MacOS

Language

Typescript

Language Version

No response

Other information

#23351 (comment) - referenced in this issue

@roketworks roketworks added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 5, 2023
@github-actions github-actions bot added the @aws-cdk/aws-apprunner Related to the apprunner package label Jul 5, 2023
@roketworks
Copy link
Contributor Author

#23351 (comment) - issue referenced here

@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 5, 2023
@peterwoodworth
Copy link
Contributor

Would be an easy fix, feel free to submit a PR

@roketworks
Copy link
Contributor Author

PR opened here #26238

@mergify mergify bot closed this as completed in #26238 Jul 7, 2023
mergify bot pushed a commit that referenced this issue Jul 7, 2023
Use `serviceName` property when creating CfnService resource. 

BREAKING CHANGE: This change will be destructive if the `serviceName` is set on an existing resources.

Closes #26237 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

tmokmss pushed a commit to tmokmss/aws-cdk that referenced this issue Jul 9, 2023
Use `serviceName` property when creating CfnService resource. 

BREAKING CHANGE: This change will be destructive if the `serviceName` is set on an existing resources.

Closes aws#26237 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
Use `serviceName` property when creating CfnService resource. 

BREAKING CHANGE: This change will be destructive if the `serviceName` is set on an existing resources.

Closes aws#26237 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apprunner Related to the apprunner package bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants