Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apprunner-alpha): respect serviceName property #26238

Merged
merged 4 commits into from
Jul 7, 2023
Merged

fix(apprunner-alpha): respect serviceName property #26238

merged 4 commits into from
Jul 7, 2023

Conversation

roketworks
Copy link
Contributor

@roketworks roketworks commented Jul 5, 2023 •
edited by colifran
Loading

Use serviceName property when creating CfnService resource.

BREAKING CHANGE: This change will be destructive if the serviceName is set on an existing resources.

Closes #26237

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 5, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team July 5, 2023 08:58
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Jul 5, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@roketworks roketworks changed the title fix(aws-apprunner-alpha): respect serviceName property fix(apprunner-alpha): respect serviceName property Jul 5, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 5, 2023 09:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 5, 2023
@colifran colifran self-assigned this Jul 5, 2023
@roketworks roketworks mentioned this pull request Jul 5, 2023
Closed
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Jul 7, 2023
colifran
colifran previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for your contribution!

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed colifran’s stale review July 7, 2023 15:39

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 49178a4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6da9a4c into aws:main Jul 7, 2023
5 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

tmokmss pushed a commit to tmokmss/aws-cdk that referenced this pull request Jul 9, 2023
@roketworks @tmokmss
fix(apprunner-alpha): respect serviceName property (aws#26238)
cb5f5cb 
Use `serviceName` property when creating CfnService resource. 

BREAKING CHANGE: This change will be destructive if the `serviceName` is set on an existing resources.

Closes aws#26237 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@roketworks @bmoffatt
fix(apprunner-alpha): respect serviceName property (aws#26238)
a24e6cd 
Use `serviceName` property when creating CfnService resource. 

BREAKING CHANGE: This change will be destructive if the `serviceName` is set on an existing resources.

Closes aws#26237 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colifran colifran colifran approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@colifran colifran

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-apprunner-alpha): serviceName property being ignored
3 participants
@roketworks @aws-cdk-automation @colifran