Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ecs): The current Windows ECS optimized ssm params format is incorrect #26327

Closed
arun-annamalai opened this issue Jul 11, 2023 · 2 comments · Fixed by #26326
Closed

(ecs): The current Windows ECS optimized ssm params format is incorrect #26327

arun-annamalai opened this issue Jul 11, 2023 · 2 comments · Fixed by #26326
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@arun-annamalai
Copy link
Contributor

arun-annamalai commented Jul 11, 2023 •
edited
Loading

Describe the bug

The current Windows ECS optimized ssm params format is incorrect.

Current incorrect format: /aws/service/ecs/optimized-ami/windows_server/${this.windowsVersion}/english/full/recommended/image_id

Correct format: /aws/service/ami-windows-latest/Windows_Server-${this.windowsVersion}-English-Full-ECS_Optimized

Expected Behavior

Correct format: /aws/service/ami-windows-latest/Windows_Server-${this.windowsVersion}-English-Full-ECS_Optimized

Current Behavior

Current incorrect format: /aws/service/ecs/optimized-ami/windows_server/${this.windowsVersion}/english/full/recommended/image_id

Reproduction Steps

N/A

Possible Solution

The correct format can be found in the public documentation to customers: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_windows_AMI.html

Additional Information/Context

No response

CDK CLI Version

All

Framework Version

No response

Node.js Version

All

OS

All

Language

Typescript

Language Version

No response

Other information

No response
@arun-annamalai arun-annamalai added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 11, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jul 11, 2023
@arun-annamalai arun-annamalai mentioned this issue Jul 11, 2023
Merged
arun-annamalai added a commit to arun-annamalai/aws-cdk that referenced this issue Jul 11, 2023
@arun-annamalai
fix(ecs): Correct Windows ECS Optimized AMI SSM parameter
7d88e3f 
The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_windows_AMI.html)

Closes aws#26327.
arun-annamalai added a commit to arun-annamalai/aws-cdk that referenced this issue Jul 12, 2023
@arun-annamalai
fix(ecs): Correct Windows ECS Optimized AMI SSM parameter
c776c74 
The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_windows_AMI.html)

Closes aws#26327.
@pahud
Copy link
Contributor

pahud commented Jul 12, 2023

Thank you for your report and pull request. Yes we should fix that.

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2023
@mergify mergify bot closed this as completed in #26326 Jul 12, 2023
mergify bot pushed a commit that referenced this issue Jul 12, 2023
@arun-annamalai
fix(ecs): Windows ECS Optimized AMI SSM parameter format is incorrect (…
43013d0 
…#26326)

The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_windows_AMI.html)

```
Current incorrect format:
/aws/service/ecs/optimized-ami/windows_server/${this.windowsVersion}/english/full/recommended/image_id
Correct format: 
/aws/service/ami-windows-latest/Windows_Server-${this.windowsVersion}-English-Full-ECS_Optimized
```

Closes #26327.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
@arun-annamalai @bmoffatt
fix(ecs): Windows ECS Optimized AMI SSM parameter format is incorrect (…
b2ff8c7 
…aws#26326)

The format of the Windows ECS optimized ssm parameter used by CDK is incorrect. The correct format can be found [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_windows_AMI.html)

```
Current incorrect format:
/aws/service/ecs/optimized-ami/windows_server/${this.windowsVersion}/english/full/recommended/image_id
Correct format: 
/aws/service/ami-windows-latest/Windows_Server-${this.windowsVersion}-English-Full-ECS_Optimized
```

Closes aws#26327.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ecs): Windows ECS Optimized AMI SSM parameter format is incorrect arun-annamalai/aws-cdk
2 participants
@pahud @arun-annamalai