Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-neptune: no CDK for Neptune Serverless #26428

Closed
2 tasks
MieladNiekzad opened this issue Jul 19, 2023 · 2 comments · Fixed by #26445
Closed
2 tasks

aws-neptune: no CDK for Neptune Serverless #26428

MieladNiekzad opened this issue Jul 19, 2023 · 2 comments · Fixed by #26445
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@MieladNiekzad
Copy link

Describe the feature

On the 26th of October 2022, AWS released serverless Neptune (a graph database). About 2 months ago, AWS released Cloudformation support for serverless Neptune, which means now serverless Neptune can be made with Cloudformation files.

It would be pretty useful to create constructs for serverless Neptune. Currently these do not exist.

Use Case

At present, you can only choose instances when building Neptune with CDK. There is no ability to go serverless. Neptune is pretty costly, so even at its smallest size, it costs a pretty penny. Having the ability to write the configuration for serverless Neptune in CDK would be a lifesaver (& prevent us from constantly using the GUI). The benefits of IaC are obviously innumerable.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.87.0

Environment details (OS name and version, etc.)

Windows/Mac/Linux
@MieladNiekzad MieladNiekzad added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 19, 2023
@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label Jul 19, 2023
@khushail khushail added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 19, 2023
@khushail khushail self-assigned this Jul 19, 2023
@khushail
Copy link
Contributor

khushail commented Jul 19, 2023 •
edited
Loading

Hi @MieladN , thanks for coming up with this feature in existing Neptune construct in CDK. For the time being, you could follow this article to convert DB instance to serverless. We would be happy to review PRs from the community in this context.

@khushail khushail added p2 effort/medium Medium work item – several days of effort and removed response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Jul 19, 2023
@khushail khushail removed their assignment Jul 19, 2023
@lpizzinidev lpizzinidev mentioned this issue Jul 20, 2023
Merged
lpizzinidev added a commit to lpizzinidev/aws-cdk that referenced this issue Jul 25, 2023
@lpizzinidev
Merge branch 'main' into awsgh-26428
42b4f65
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Jul 25, 2023
@mergify
Merge branch 'main' into awsgh-26428
8f1959b
@mergify mergify bot closed this as completed in #26445 Jul 25, 2023
mergify bot pushed a commit that referenced this issue Jul 25, 2023
@lpizzinidev
feat(neptune-alpha): support for Neptune serverless (#26445)
b42dbc8 
Adds support for [Neptune serverless](https://docs.aws.amazon.com/neptune/latest/userguide/neptune-serverless-using.html).

Example of how to launch a Neptune serverless cluster:
```
new DatabaseCluster(stack, 'Database', {
  vpc,
  instanceType: InstanceType.SERVERLESS,
  clusterParameterGroup,
  removalPolicy: cdk.RemovalPolicy.DESTROY,
  serverlessScalingConfiguration: {
    minCapacity: 1,
    maxCapacity: 5,
  },
});
```

Closes #26428 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
@lpizzinidev @bmoffatt
feat(neptune-alpha): support for Neptune serverless (aws#26445)
f1a54ec 
Adds support for [Neptune serverless](https://docs.aws.amazon.com/neptune/latest/userguide/neptune-serverless-using.html).

Example of how to launch a Neptune serverless cluster:
```
new DatabaseCluster(stack, 'Database', {
  vpc,
  instanceType: InstanceType.SERVERLESS,
  clusterParameterGroup,
  removalPolicy: cdk.RemovalPolicy.DESTROY,
  serverlessScalingConfiguration: {
    minCapacity: 1,
    maxCapacity: 5,
  },
});
```

Closes aws#26428 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(neptune-alpha): support for Neptune serverless lpizzinidev/aws-cdk
2 participants
@khushail @MieladNiekzad