-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
synthetics: cdk requires handler to end in .handler when synthetics do not #26540
Labels
@aws-cdk/aws-synthetics
Related to Amazon CloudWatch Synthetics
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
good first issue
Related to contributions. See CONTRIBUTING.md
p2
Comments
kaizencc
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 27, 2023
github-actions
bot
added
the
@aws-cdk/aws-synthetics
Related to Amazon CloudWatch Synthetics
label
Jul 27, 2023
kaizencc
added
good first issue
Related to contributions. See CONTRIBUTING.md
p2
effort/small
Small work item – less than a day of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 27, 2023
lpizzinidev
added a commit
to lpizzinidev/aws-cdk
that referenced
this issue
Aug 2, 2023
mergify bot
pushed a commit
that referenced
this issue
Aug 2, 2023
This fix updates handler validation based on Synthetic rules for [Node](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_WritingCanary_Nodejs.html#:~:text=and%20files.-,Handler%20name,-Be%20sure%20to) and [Python](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_WritingCanary_Python.html#:~:text=Packaging%20your%20canary%20files) runtimes. Closes #26540. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-synthetics
Related to Amazon CloudWatch Synthetics
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
good first issue
Related to contributions. See CONTRIBUTING.md
p2
Describe the bug
From the docs:
Currently CDK enforces that the
handler
is named filename.handler for all runtimes, which is too strict.Expected Behavior
CDK enforces what Synthetics enforces
Current Behavior
CDK enforces legacy rules.
Reproduction Steps
n/a
Possible Solution
Removing the synth-time check that enforces this rule.
Additional Information/Context
No response
CDK CLI Version
latest
Framework Version
No response
Node.js Version
latest
OS
latest
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: