Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS Step Functions callback patterns in workflow #2658

Closed
albegali opened this issue May 28, 2019 · 2 comments · Fixed by #2686 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
feature-request A feature should be added or improved.

Comments

@albegali
Copy link
Contributor

In order to support Callback patterns in workflow, there is the need to append .waitForTaskToken string to resourceArn for the following task types:

  • InvokeFunction
  • PublishToTopic
  • SendToQueue
  • RunEcsFargateTask

I will submit a PR for this, looking forward to the comments and review.

@albegali albegali added the feature-request A feature should be added or improved. label May 28, 2019
@eladb
Copy link
Contributor

eladb commented May 29, 2019

Sounds great.

albegali pushed a commit to albegali/aws-cdk that referenced this issue May 30, 2019
…ix in resourceArn (aws#2658)

* Add waitForTaskToken property to SentToQueue, InvokeFunction, PublishToTopic task types
* Add payload parameter to InvokeLambda parameters
* Unit test

BREAKING CHANGE: InvokeFunction now requires props as second argument
albegali pushed a commit to albegali/aws-cdk that referenced this issue Jun 4, 2019
…ix in resourceArn (aws#2658)

* Merge awslabs:master into albegali:master
* Resolved conflicts
albegali pushed a commit to albegali/aws-cdk that referenced this issue Jun 4, 2019
…ix in resourceArn (aws#2658)

* InvokeFunction props is now optional
* Payload can have multiple nesting levels
* Unit test
* Integration test
* Invoke lambda via SFN integrated service ARN
rix0rrr pushed a commit that referenced this issue Jun 18, 2019
This PR allows one to work with Task states that implement the callback service integration pattern.

Introduces a new class for integrating with Lambda in the new invocation style, since there are a number
of subtle differences with the old invocation style.

The supported task types are:

* `RunLambdaTask` (AWS Lambda)
* `SendToQueue` (AWS SQS)
* `PublishToTopic` (AWS SNS)

Closes #2658, closes #2735.
This was referenced Dec 12, 2019
@qihsh
Copy link

qihsh commented Jun 4, 2020

Is it done for RunEcsFargateTask? I could not find relevant documentation regarding setting waitForTaskToken for RunEcsFargateTask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment