Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cli-lib-alpha): Missing hotswap option in the deploy command #26785

Closed
1 of 2 tasks
amine-mf opened this issue Aug 17, 2023 · 9 comments · Fixed by #26786
Closed
1 of 2 tasks

(cli-lib-alpha): Missing hotswap option in the deploy command #26785

amine-mf opened this issue Aug 17, 2023 · 9 comments · Fixed by #26786
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI

Comments

@amine-mf
Copy link
Contributor

amine-mf commented Aug 17, 2023 •
edited
Loading

Describe the feature

I'm missing the hotswap deployment option in the CDK CLI that is mandatory for our use case.

Use Case

We use a lambda to deploy state machines, without the hotswap it is way too slow for our use.
We are currently using an older version of CDK and trying to upgrade. So we are adapting our code to use cli-lib-alpha instead of using SdkProvider and CloudFormationDeployments.

Proposed Solution

#26786

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.92.0

Environment details (OS name and version, etc.)

macOS Ventura
@amine-mf amine-mf added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Aug 17, 2023
@amine-mf amine-mf mentioned this issue Aug 17, 2023
Merged
@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2023
@peterwoodworth
Copy link
Contributor

Thanks for the request and PR 🙂

@fab-mindflow
Copy link

fab-mindflow commented Aug 19, 2023 •
edited
Loading

Our team has intensively used internal API to run CDK in lambdas until now. We are in the process to move to cli-lib because we need to stick with latest CDK version. Hence the work by @amine-mf because this is blocking for us. We will continue to provide feedback as needed on this module as we migrate. Do you think this can be merged pretty soon in upcoming release so that we don't fork meanwhile?

@amine-mf
Copy link
Contributor Author

@peterwoodworth Any chance the PR gets reviewed soon? As mentioned by @fab-mindflow this is quite blocking for us and the PR content is pretty small, the review should be quick and easy.
Thank you

@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
@khushail khushail mentioned this issue Sep 1, 2023
Open
@amine-mf
Copy link
Contributor Author

amine-mf commented Sep 7, 2023

@peterwoodworth A gentle reminder. Thanks a lot. (Sorry to insist, but we really need it)

@github-actions
Copy link

This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue.

@github-actions github-actions bot added p1 and removed p2 labels Sep 10, 2023
@mergify mergify bot closed this as completed in #26786 Sep 18, 2023
mergify bot pushed a commit that referenced this issue Sep 18, 2023
@amine-mf
feat(cli-lib-alpha): support hotswap deployments (#26786)
e01faff 
Closes #26785.

Exemption Request: The `cli-lib-alpha` README does not currently specify the exhaustive list of arguments, which looks like a choice, thus I did not add the new argument. Currently, no integration tests were implemented for this lib, only unit tests which I did update/add.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

HBobertz pushed a commit that referenced this issue Sep 18, 2023
@amine-mf
feat(cli-lib-alpha): support hotswap deployments (#26786)
301227a 
Closes #26785.

Exemption Request: The `cli-lib-alpha` README does not currently specify the exhaustive list of arguments, which looks like a choice, thus I did not add the new argument. Currently, no integration tests were implemented for this lib, only unit tests which I did update/add.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@amine-mf
Copy link
Contributor Author

amine-mf commented Sep 19, 2023 •
edited
Loading

@mrgrain I have no idea on your release process, is there a way to know when is the next release?
🙏

@mrgrain
Copy link
Contributor

mrgrain commented Sep 19, 2023 •
edited
Loading

@mrgrain I have no idea on your release process, is there a way to know when is the next release? 🙏

We release weekly, usually Wednesdays. But various things can affect this.
For this week we seem to be on track.

I spoke too soon. Looks like it will be Friday this week.

@mrgrain
Copy link
Contributor

mrgrain commented Sep 19, 2023

I spoke too soon. Looks like it will be Friday this week. @amine-mf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli-lib-alpha): support hotswap deployments
4 participants
@mrgrain @peterwoodworth @fab-mindflow @amine-mf