Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-cdk-lib.custom_resources: unfinished comments #26892

Closed
WeijianL1 opened this issue Aug 25, 2023 · 1 comment · Fixed by #27512
Closed

aws-cdk-lib.custom_resources: unfinished comments #26892

WeijianL1 opened this issue Aug 25, 2023 · 1 comment · Fixed by #27512
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2

Comments

@WeijianL1
Copy link

Describe the issue

On this line

aws-cdk/packages/aws-cdk-lib/custom-resources/lib/provider-framework/runtime/framework.ts

Line 22 in 9cb395c

* This function will always succeed. If an error occurs

It doesn't finish the sentence. If an error occus... then what?

Links

aws-cdk/packages/aws-cdk-lib/custom-resources/lib/provider-framework/runtime/framework.ts

Line 22 in 9cb395c

* This function will always succeed. If an error occurs

@WeijianL1 WeijianL1 added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Aug 25, 2023
@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Aug 25, 2023
@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 25, 2023
@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
@msambol msambol mentioned this issue Oct 12, 2023
Merged
@mergify mergify bot closed this as completed in #27512 Oct 18, 2023
mergify bot pushed a commit that referenced this issue Oct 18, 2023
@msambol
docs(custom-resources): complete documentation for onEvent (#27512)
06158f5 
Closes #26892.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(custom-resources): complete documentation for onEvent msambol/aws-cdk
2 participants
@WeijianL1 @khushail