Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lambda-events AwsApi needs updating to Node18 and SDKv3 #26998

Closed
mrgrain opened this issue Sep 4, 2023 · 1 comment · Fixed by #27002
Closed

lambda-events AwsApi needs updating to Node18 and SDKv3 #26998

mrgrain opened this issue Sep 4, 2023 · 1 comment · Fixed by #27002
Assignees
@mrgrain
Labels
@aws-cdk/aws-events-targets node18-upgrade Any work (bug, feature) related to Node 18 upgrade p1 sdk-v3-upgrade Tag issues that are associated to SDK V3 upgrade. Not limited to CR usage of SDK only.

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Sep 4, 2023 •
edited
Loading

Describe the bug

The handler function in AwsApi is using Node16 and SDKv2.
It should use Node18 and SDKv3.

Expected Behavior

It is using node 18

Current Behavior

Using node 16

Reproduction Steps

N/A

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.94.0

Framework Version

2.94.0

Node.js Version

Any

OS

Any

Language

Typescript, Python, .NET, Java, Go

Language Version

No response

Other information

No response
@mrgrain mrgrain added sdk-v3-upgrade Tag issues that are associated to SDK V3 upgrade. Not limited to CR usage of SDK only. node18-upgrade Any work (bug, feature) related to Node 18 upgrade labels Sep 4, 2023
@mrgrain mrgrain self-assigned this Sep 4, 2023
@mrgrain mrgrain mentioned this issue Sep 4, 2023
Merged
@mergify mergify bot closed this as completed in #27002 Sep 6, 2023
mergify bot pushed a commit that referenced this issue Sep 6, 2023
@mrgrain
fix(events-targets): AwsApi is still using Node 16 (#27002)
49e5739 
Migrate the `aws-api-handler` code to use SDKv3 and move it into `custom-resource-handlers`.
Updates the Construct config to use the new code and Node18.
To verify functionality, the existing integration test has been extended to include a new rule and target that can be asserted on.

Includes a config change to the `custom-resource-handlers` package to run test from TS.

Closes #26998

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mikewrighton pushed a commit that referenced this issue Sep 14, 2023
@mrgrain
fix(events-targets): AwsApi is still using Node 16 (#27002)
d832427 
Migrate the `aws-api-handler` code to use SDKv3 and move it into `custom-resource-handlers`.
Updates the Construct config to use the new code and Node18.
To verify functionality, the existing integration test has been extended to include a new rule and target that can be asserted on.

Includes a config change to the `custom-resource-handlers` package to run test from TS.

Closes #26998

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrgrain mrgrain

Labels
@aws-cdk/aws-events-targets node18-upgrade Any work (bug, feature) related to Node 18 upgrade p1 sdk-v3-upgrade Tag issues that are associated to SDK V3 upgrade. Not limited to CR usage of SDK only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(events-targets): AwsApi is still using Node 16 aws/aws-cdk
1 participant
@mrgrain