Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@aws-cdk/aws-lambda-python-alpha: allow "--without-urls" option to poetry export #27103

Closed
2 tasks
lokucrazy opened this issue Sep 11, 2023 · 5 comments · Fixed by #27442
Closed
2 tasks

@aws-cdk/aws-lambda-python-alpha: allow "--without-urls" option to poetry export #27103

lokucrazy opened this issue Sep 11, 2023 · 5 comments · Fixed by #27442
Assignees
@msambol
Labels
@aws-cdk/aws-lambda-python effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@lokucrazy
Copy link

Describe the feature

I would like the poetry export command to be able to export without the url.

Use Case

the projects I would like to use cdk and poetry with use an authenticated codeartifact url for dependencies which are sourced in the pyproject.toml.

When Poetry exports a requirements.txt it has an un-auth'd URL in the file which causes any install to fail waiting for username and password input. Being able to export without a url would fix this problem.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.85.0

Environment details (OS name and version, etc.)

Mac OS 13.5.1 (22G90)
@lokucrazy lokucrazy added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 11, 2023
@khushail khushail added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Sep 11, 2023
@khushail
Copy link
Contributor

Hi @lokucrazy , thanks for reaching out. Looking at the existing packaging props, this request would be a good addition to have.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Sep 11, 2023
@msambol
Copy link
Contributor

msambol commented Sep 15, 2023

@khushail I'll take this.

@khushail
Copy link
Contributor

sounds good. Thanks @msambol

@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
@msambol msambol mentioned this issue Oct 7, 2023
Merged
@mergify mergify bot closed this as completed in #27442 Oct 10, 2023
mergify bot pushed a commit that referenced this issue Oct 10, 2023
@msambol
feat(lambda-python-alpha): add without-urls option for poetry (#27442)
5893b3f 
Added `without-urls` option for poetry. Also added Python versions for the integration tests.

Closes #27103.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@lokucrazy
Copy link
Author

@msambol thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msambol msambol

Labels
@aws-cdk/aws-lambda-python effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lambda-python-alpha): add without-urls option for poetry msambol/aws-cdk
3 participants
@msambol @lokucrazy @khushail