Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-codepipeline-actions integ test not working #27117

Closed
mrgrain opened this issue Sep 12, 2023 · 2 comments · Fixed by #27120
Closed

aws-codepipeline-actions integ test not working #27117

mrgrain opened this issue Sep 12, 2023 · 2 comments · Fixed by #27120
Labels
@aws-cdk/aws-codepipeline-actions effort/small Small work item – less than a day of effort p2

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Sep 12, 2023 •
edited
Loading

aws-codepipeline-actions/test/integ.pipeline-elastic-beanstalk-deploy.ts is currently not working.

During the execution of the CodePipeline, the file aws-codepipeline-actions/test/assets/nodejs.zip is accessed. This is supposed to be a ZIP archive of configuration for ElasticBeanstalk. However the file is corrupted now and not a working ZIP archive anymore.

I suspect we just need to track down a working version of this file and we are good. Potentially exists on an earlier commit or the v1 branch.

This is not a bug in the construct, it is simply a broken integ test.
@peterwoodworth peterwoodworth added bug This issue is a bug. p1 @aws-cdk/aws-codepipeline-actions effort/small Small work item – less than a day of effort labels Sep 12, 2023
@msambol
Copy link
Contributor

msambol commented Sep 12, 2023

@peterwoodworth I'll take this.

@msambol msambol mentioned this issue Sep 12, 2023
Merged
@mrgrain mrgrain added p2 and removed p1 bug This issue is a bug. labels Sep 13, 2023
@mergify mergify bot closed this as completed in #27120 Sep 13, 2023
mergify bot pushed a commit that referenced this issue Sep 13, 2023
@msambol
fix(codepipeline-actions): update zip to noncorrupted one (#27120)
eb1d363 
I found a legit zip [here](https://github.com/aws/aws-cdk/blob/d8acc8aa07867be1b1b3cad05b67dab2d7bc3252/packages/%40aws-cdk/aws-codepipeline-actions/test/assets/nodejs.zip). 

Closes #27117.

<img width="1211" alt="Screenshot 2023-09-12 at 6 46 22 PM" src="https://github.com/aws/aws-cdk/assets/3310356/1de56fcf-1f99-4095-b2d9-1668bd443a9f">

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mikewrighton pushed a commit that referenced this issue Sep 14, 2023
@msambol
fix(codepipeline-actions): update zip to noncorrupted one (#27120)
8b6ff36 
I found a legit zip [here](https://github.com/aws/aws-cdk/blob/d8acc8aa07867be1b1b3cad05b67dab2d7bc3252/packages/%40aws-cdk/aws-codepipeline-actions/test/assets/nodejs.zip). 

Closes #27117.

<img width="1211" alt="Screenshot 2023-09-12 at 6 46 22 PM" src="https://github.com/aws/aws-cdk/assets/3310356/1de56fcf-1f99-4095-b2d9-1668bd443a9f">

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codepipeline-actions effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(codepipeline-actions): update zip to noncorrupted one msambol/aws-cdk
3 participants
@mrgrain @msambol @peterwoodworth