-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poor usability of S3 Bucket encryption #2714
Closed
skinny85 opened this issue
May 31, 2019
· 0 comments
· Fixed by #2719 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed
Poor usability of S3 Bucket encryption #2714
skinny85 opened this issue
May 31, 2019
· 0 comments
· Fixed by #2719 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
@aws-cdk/aws-s3
Related to Amazon S3
Comments
eladb
pushed a commit
that referenced
this issue
Jun 3, 2019
If `encryptionKey` is specified, defaults to KMS encryption. Fixes #2714
4 tasks
eladb
pushed a commit
that referenced
this issue
Jun 3, 2019
If `encryptionKey` is specified, defaults to KMS encryption. Fixes #2714
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I say:
I get a validation error:
This customer experience is not up to the CDK bar. If you know what should be specified in the
encryption
property, why are you forcing me to do it? Why should I have to tell you I want encryption twice?(Now, if I explicitly specify both
encryptionKey: key
andencryption: s3.BucketEncryption.Unencrypted
(note: different enum constant name than the NONE in the error message above!), fine, hit me with that validation error. But it should not happen by default)The text was updated successfully, but these errors were encountered: