aws-cdk-lib/aws-sns-subscriptions: Cannot add SqsSubscription when using an Sqs Construct from a SymLinked Constructs Library

[gastonsilva]

Describe the bug

Users can't add an SqsSubscription to an Sns Topic using the "addSubscription" method when the created queue came from a symlinked constructs library

Expected Behavior

Users can add an SqsSubscription to an Sns Topic using the "addSubscription" method regardless of whether it came from a symlinked constructs library or not

Current Behavior

Stack trace:

Error: The supplied Queue object must be an instance of Construct
    at SqsSubscription.bind (/home/user/project/node_modules/aws-cdk-lib/aws-sns-subscriptions/lib/sqs.js:1:1024)
    at Topic.addSubscription (/home/user/project/node_modules/aws-cdk-lib/aws-sns/lib/topic-base.js:1:1018)
    at new NamedStack (/home/user/project/lib/SomeStack.ts:10:10) ...

Reproduction Steps

1. npm link a construct library locally that has a sqs queue construct.
2. Create a new sqs queue from that construct library
3. Create an SNS topic using new Topic
4. Add a new sqs subscription to the topic using the addSubscription method and new SqsSubscription
5. run cdk synth

Example code:

const queue = new QueueFromSymLinkedLibrary(this, 'Queue');
const topic = new Topic(this, 'Topic');
topic.addSubscription(new SqsSubscription(queue));

Possible Solution

aws-cdk/packages/@aws-cdk/aws-sns-subscriptions/lib/sqs.ts

Lines 33 to 38 in f3fd183

	public bind(topic: sns.ITopic): sns.TopicSubscriptionConfig {
	// Create subscription under *consuming* construct to make sure it ends up
	// in the correct stack in cases of cross-stack subscriptions.
	if (!(this.queue instanceof Construct)) {
	throw new Error('The supplied Queue object must be an instance of Construct');
	}

This guard clause should be:

    if (!Construct.isConstruct(this.queue)) {
      throw new Error('The supplied Queue object must be an instance of Construct');
    }

Reference: aws/constructs@bef8e4d

Additional Information/Context

No response

CDK CLI Version

2.93.0

Framework Version

No response

Node.js Version

18

OS

Ubuntu 22.04.3 LTS

Language

Typescript

Language Version

4.9.5

Other information

No response

[peterwoodworth]

Thanks for the research into this and the pull request! It's much appreciated 🙂

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.