Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❗ NOTICE ecs: v2.96.0 introduces breaking change by renaming tag prop in ContainerImage.fromEcrRepository function #27240

Closed
sumupitchayan opened this issue Sep 21, 2023 · 1 comment
Labels
management/tracking Issues that track a subject or multiple issues p0

Comments

@sumupitchayan
Copy link
Contributor

Status

Resolved

What is the issue?

Renaming the tag prop to tagOrDigest of the ContainerImage.fromEcrRepository function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function in v2.96.0

Error message

TypeError: from_ecr_repository() got an unexpected keyword argument 'tag'

What is the impact?

The CDK code will not compile in languages that require specifying the property name when calling the function (not typescript).

Workaround

Rename the property to tagOrDigest in your code, or upgrade to CDK v2.96.1 or later

Who is affected?

CDK users of languages that require specifying the property name when calling the function, using the ContainerImage.fromEcrRepository function.

How do I resolve this?

Upgrade to v2.96.1 or later

Related issues

No response

@sumupitchayan sumupitchayan added management/tracking Issues that track a subject or multiple issues p0 labels Sep 21, 2023
@sumupitchayan sumupitchayan changed the title ❗ NOTICE (module name): (short notice description) ❗ NOTICE ecs: v2.96.0 introduces breaking change by renaming tag prop in ContainerImage.fromEcrRepository function Sep 21, 2023
@sumupitchayan sumupitchayan pinned this issue Sep 21, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mergify bot pushed a commit to cdklabs/aws-cdk-notices that referenced this issue Sep 25, 2023
@MrArnoldPalmer MrArnoldPalmer unpinned this issue Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
management/tracking Issues that track a subject or multiple issues p0
Projects
None yet
Development

No branches or pull requests

1 participant