Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-resources): cannot set logging for state machine generated in CompleteHandler #27310

Merged
merged 64 commits into from
Dec 20, 2023
Merged

fix(custom-resources): cannot set logging for state machine generated in CompleteHandler #27310

merged 64 commits into from
Dec 20, 2023

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Sep 27, 2023 •
edited
Loading

This PR fixes the case that StateMachine generated for CompleteHandler in Provider cannot set logging.

Closes #27283.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Sep 27, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 27, 2023 07:21
@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Sep 27, 2023
@go-to-k go-to-k changed the title fix(custom-resources): StateMachine in Provider cannot set logging fix(custom-resources): StateMachine for isCompleteHandler in Provider cannot set logging Sep 27, 2023
@go-to-k go-to-k changed the title fix(custom-resources): StateMachine for isCompleteHandler in Provider cannot set logging fix(custom-resources): StateMachine for CompleteHandler in Provider cannot set logging Sep 27, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 27, 2023 10:17

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation
aws-cdk-automation previously requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 27, 2023 11:54

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0e7aeb9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bfeef00 into aws:main Dec 20, 2023
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@pahud pahud mentioned this pull request Jan 4, 2024
Closed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@go-to-k @paulhcsun
fix(custom-resources): cannot set logging for state machine generated…
9bde761 
… in CompleteHandler (aws#27310)

This PR fixes the case that `StateMachine` generated for `CompleteHandler` in `Provider` cannot set logging.

Closes aws#27283.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
MrArnoldPalmer added a commit that referenced this pull request Jan 12, 2024
@MrArnoldPalmer
revert: allowing log group config for SFN CR
699f2fb 
Reverts #27310 which allows setting up LogGroups for the state machine
configured by the waiter custom-resource.

Refs: bfeef00

This reverts commit bfeef00.
@MrArnoldPalmer MrArnoldPalmer mentioned this pull request Jan 12, 2024
Merged
MrArnoldPalmer added a commit that referenced this pull request Jan 12, 2024
@MrArnoldPalmer
revert: allowing log group config for SFN CR
455f6cc 
Reverts #27310 which allows setting up LogGroups for the state machine
configured by the waiter custom-resource.

Refs: bfeef00

This reverts commit bfeef00.
mergify bot pushed a commit that referenced this pull request Jan 13, 2024
@MrArnoldPalmer
revert: allowing log group config for SFN CR (#28699)
8a67f39 
Reverts #27310 which allows setting up LogGroups for the state machine configured by the waiter custom-resource.

Refs: bfeef00

This reverts commit bfeef00.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
MrArnoldPalmer added a commit that referenced this pull request Jan 13, 2024
@MrArnoldPalmer
revert: allowing log group config for SFN CR (#28699)
f3f217e 
Reverts #27310 which allows setting up LogGroups for the state machine configured by the waiter custom-resource.

Refs: bfeef00

This reverts commit bfeef00.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jan 14, 2024
Merged
Closed
This was referenced Feb 10, 2024
Open
Open
Open
mergify bot pushed a commit that referenced this pull request Apr 19, 2024
@go-to-k
fix(custom-resources): cannot set logging for state machine generated…
99041b2 
… in CompleteHandler (#28706)

This PR fixes the case that `StateMachine` generated for `CompleteHandler` in `Provider` cannot set logging.

The default log group name of the state machine automatically created by the `Provider` with `isCompleteHandler` should start with `/aws/vendedlogs/states`. Otherwise, each time the state machine is created, the log resource policy size increases. 

https://docs.aws.amazon.com/step-functions/latest/dg/bp-cwl.html

Closes #27283
Fixes #28577 #28744

Related PR #27310(reverted by #28699), #28587

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced May 23, 2024
Open
Open
@rwlxxvii rwlxxvii mentioned this pull request May 27, 2024
Merged
@NOUIY NOUIY mentioned this pull request May 30, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this pull request Jun 13, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 14, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 20, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 21, 2024
Open
@rwlxxvii rwlxxvii mentioned this pull request Jun 22, 2024
Merged
This was referenced Jun 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom resources: Generated step function generates finding due to missing logging
4 participants
@go-to-k @aws-cdk-automation @lpizzinidev @kaizencc