fix(custom-resources): log group name for waiter state machine does not start with /aws/vendedlogs/states/ (under feature flag)
#28587
Conversation
…CompleteHandler does not start `/aws/vendedlogs/states` (under feature flag)
github-actions
bot
added
bug
go-to-k
changed the title
/aws/vendedlogs/states (under feature flag)/aws/vendedlogs/states (under feature flag)
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
go-to-k
changed the title
/aws/vendedlogs/states (under feature flag)/aws/vendedlogs/states/ (under feature flag)
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| const logGroup = logOptions?.destination ?? new LogGroup(this, 'LogGroup'); | ||
| const logGroupName = | ||
| FeatureFlags.of(this).isEnabled(cxapi.WAITER_STATE_MACHINE_LOG_GROUP_NAME) | ||
| ? `/aws/vendedlogs/states/waiter-state-machine-${this.isCompleteHandler.functionName}-${this.node.addr}` |
There was a problem hiding this comment.
node.addr is used to prevent duplicate names no matter how many times this construct is created in the stack. It will not duplicate if called on other stacks.
Also, by using the (auto-generated) name of the Lambda created in the Provider that calls this WaiterStateMachine construct, even if the Provider (or its parent) is deleted and then created again, the log group name will not duplicate previously created one with removal policy RETAIN. (This is because that lambda will be re-created again with auto-generated name.)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
I am going to take the original issue with correct changes in a new PR. |
… in CompleteHandler (#28706) This PR fixes the case that `StateMachine` generated for `CompleteHandler` in `Provider` cannot set logging. The default log group name of the state machine automatically created by the `Provider` with `isCompleteHandler` should start with `/aws/vendedlogs/states`. Otherwise, each time the state machine is created, the log resource policy size increases. https://docs.aws.amazon.com/step-functions/latest/dg/bp-cwl.html Closes #27283 Fixes #28577 #28744 Related PR #27310(reverted by #28699), #28587 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Until now, the default log group name of the state machine automatically created by the
ProviderwithisCompleteHandlerdid not start with/aws/vendedlogs/states. Therefore, each time the state machine is created, the log resource policy size increases. To prevent this, the log group name of automatically created logs now starts with/aws/vendedlogs/states.Closes #28577.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license