Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(synthetics): CloudWatch Synthetics NodeJS Pupeteer 6.0 Runtime with NodeJS 18 #27339

Merged
merged 4 commits into from
Sep 29, 2023
Merged

feat(synthetics): CloudWatch Synthetics NodeJS Pupeteer 6.0 Runtime with NodeJS 18 #27339

merged 4 commits into from
Sep 29, 2023

Conversation

Abdu03
Copy link
Contributor

@Abdu03 Abdu03 commented Sep 28, 2023

Added syn-nodejs-puppeteer-6.0 version to avaiable synthetic runtimes.
This version runs on Node 18 allowing users to move away from node 16 (which is now at EOL).

Changed an exisiting test to refrence the latest runtime and also updated the examples in the readme to refrence the latest runtime.

Closes #27337.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Sep 28, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 28, 2023 15:51
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Abdu03 Abdu03 changed the title feat(aws-synthetics-alpha): Add latest CloudWatch Synthetics NodeJS Runtime feat(synthetics-alpha): Add latest CloudWatch Synthetics NodeJS Runtime Sep 28, 2023
@peterwoodworth peterwoodworth changed the title feat(synthetics-alpha): Add latest CloudWatch Synthetics NodeJS Runtime feat(synthetics): Add latest CloudWatch Synthetics NodeJS Runtime Sep 28, 2023
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Sep 28, 2023
peterwoodworth
peterwoodworth previously requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Abdu03, according to the build logs, the build is failing because the indentation isn't correct in runtime.ts on lines 125 and 138

Regarding integration tests, we'll need to modify and run the tests found in this folder.

@mrgrain mrgrain changed the title feat(synthetics): Add latest CloudWatch Synthetics NodeJS Runtime feat(synthetics): CloudWatch Synthetics NodeJS Pupeteer 6.0 Runtime with NodeJS 18 Sep 29, 2023
@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Sep 29, 2023
mrgrain
mrgrain previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 29, 2023 08:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed stale reviews from mrgrain and peterwoodworth September 29, 2023 08:36

Pull request has been modified.

@Abdu03
Copy link
Contributor Author

Abdu03 commented Sep 29, 2023 •
edited
Loading

thank you for clarifying @peterwoodworth 🙌 and thank you for sorting it out @mrgrain 🚀

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3d19144
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e48af04 into aws:main Sep 29, 2023
8 checks passed
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@peterwoodworth peterwoodworth peterwoodworth left review comments

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-synthetics-alpha): Node 16 End Of Life
4 participants
@Abdu03 @aws-cdk-automation @mrgrain @peterwoodworth