feat(synthetics): CloudWatch Synthetics NodeJS Pupeteer 6.0 Runtime with NodeJS 18 #27339
Conversation
github-actions
bot
added
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Abdu03
changed the title
peterwoodworth
changed the title
github-actions
bot
added
the
effort/small
There was a problem hiding this comment.
Hey @Abdu03, according to the build logs, the build is failing because the indentation isn't correct in runtime.ts on lines 125 and 138
Regarding integration tests, we'll need to modify and run the tests found in this folder.
mrgrain
changed the title
mrgrain
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mergify
bot
dismissed stale reviews from mrgrain and peterwoodworth
Pull request has been modified.
|
thank you for clarifying @peterwoodworth 🙌 and thank you for sorting it out @mrgrain 🚀 |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Added
syn-nodejs-puppeteer-6.0version to avaiable synthetic runtimes.This version runs on Node 18 allowing users to move away from node 16 (which is now at EOL).
Changed an exisiting test to refrence the latest runtime and also updated the examples in the readme to refrence the latest runtime.
Closes #27337.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license