-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-scheduler-targets-alpha): Add InspectorStartAssessmentRun Target #27453
Labels
@aws-cdk/aws-inspector
Related to Amazon Inspector
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Comments
filletofish
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Oct 9, 2023
2 tasks
Thank you for all those feature requests and PRs! |
pahud
added
p2
effort/medium
Medium work item – several days of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Oct 9, 2023
mergify bot
pushed a commit
that referenced
this issue
Nov 30, 2023
…27850) This PR adds InspectorStartAssessmentRun Target for EventBridge Scheduler. In [the issue](#27453), the `inspector.CfnAssessmentTarget` is used in the `InspectorStartAssessmentRun`. But it should be a `CfnAssessmentTemplate` so I fixed. ```ts export class InspectorStartAssessmentRun extends ScheduleTargetBase implements IScheduleTarget { constructor( private readonly target: inspector.CfnAssessmentTarget, // <- here private readonly props: ScheduleTargetBaseProps, ) { ``` Closes #27453. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
chenjane-dev
pushed a commit
to chenjane-dev/aws-cdk
that referenced
this issue
Dec 5, 2023
…ws#27850) This PR adds InspectorStartAssessmentRun Target for EventBridge Scheduler. In [the issue](aws#27453), the `inspector.CfnAssessmentTarget` is used in the `InspectorStartAssessmentRun`. But it should be a `CfnAssessmentTemplate` so I fixed. ```ts export class InspectorStartAssessmentRun extends ScheduleTargetBase implements IScheduleTarget { constructor( private readonly target: inspector.CfnAssessmentTarget, // <- here private readonly props: ScheduleTargetBaseProps, ) { ``` Closes aws#27453. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-inspector
Related to Amazon Inspector
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Describe the feature
Work to support L2 constructs for AWS Scheduler is in progress (#23394). See the approved RFC. RFC planned to add 12 templates targets, but only Lambda Invoke is currently implemented (#26575).
This issue tracks implementation of
InspectorStartAssessmentRun
target to start an AWS Inspector assessment run.Use Case
Customers would like to use templated target
InspectorStartAssessmentRun
to be able to start a record to an AWS Inspector assessment run on schedule. L2 target construct should grant required permissions to theAWS Scheduler
to start an AWS Inspector Assessment run.Proposed Solution
The proposed solution needs to be adopted to the recent examples of
LambdaInvoke
(https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-scheduler-targets-alpha/lib/lambda-invoke.ts).Solution should also include unit and integration tests.
Other Information
No response
Acknowledgements
CDK version used
2.99.1
Environment details (OS name and version, etc.)
MacOS
The text was updated successfully, but these errors were encountered: