cdk deploy: require argument if there is more than a single stack #2750
Labels
needs-triage
This issue or PR still needs to be triaged.
Comments
6 tasks
eladb
pushed a commit
that referenced
this issue
Jun 5, 2019
Fixes #1891 Testing: all toolkit integration tests passed. BREAKING CHANGE: * **cli:** This release requires CDK CLI >= 0.34.0 * **core:** `App.run()` was renamed to `App.synth()` (soft deprecation, it will be removed in the next release). * **core:** The `Stack.autoDeploy` feature has been removed. You can use `cdk deploy STACK ...` to determine which stacks to deploy (and wildcards are supported, so `cdk deploy '*'` will deploy all stacks. We plan to change the CLI to require specifying stacks if there is more than a single stack in the app (#2750). * **core:** `ConstructNode.aspects` is now private. * **core:** The `Synthesizer` has been removed. Use `ConstructNode.synth(node)` instead. * **core:** `ISynthesizable.synthesize` now accepts an `ISynthesisSession` which contains the `CloudAssemblyBuilder` object. This will allow further extension in the future. * **cx-api:** `cxapi.MissingContext` now includes the context `key` * **core:** `Stack.reportMissingContext` now accepts a single argument of type `cxapi.MissingContext`, which includes the missing context key * **core:** `Stack.annotatePhysicalName` has been removed (not used). * **core:** `Stack.missingContext` is now private. * **cx-api:** Multiple changes to the cloud assembly APIs to reduce surface area and clean up. * **cdk-integ (private):** if an integration test includes multiple stacks, use `/// !cdk-integ STACK ...` to explicitly specify which stacks to include in the test.
|
Resolved by #2772 |
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a CDK app contains more than a single stack, it may not be safe to automatically select all stacks because some of them can represent production stacks, some may represent development, gamma, different stages/environments.
We will change "cdk deploy" to require an argument (could be glob) if there is more than a single stack in the app. Today's behavior will be achievable through "cdk deploy '*'", but it will require users to be explicit about their desire to deploy all stacks.
In the future we may need to implement more advanced querying (e.g. prod/dev/stages/etc).
The text was updated successfully, but these errors were encountered: