Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❗ NOTICE: Firehose CIDR block support issue for few regions(eu-central-2, eu-south-2, ap-south-2) #27656

Closed
jstoneham opened this issue Oct 23, 2023 · 5 comments · Fixed by #27672
Assignees
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose bug This issue is a bug. management/tracking Issues that track a subject or multiple issues p0

Comments

@jstoneham
Copy link

jstoneham commented Oct 23, 2023

Please add your +1 👍 to let us know you have encountered this

Status: IN-PROGRESS

Overview:

Commit 1604cf4b88af1239253a1ecb1c411ca66f8f57b2 (1604cf) removed the Firehose CIDR blocks in packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts for eu-central-2, eu-south-2, and ap-south-2, so these constructs cannot be synthesized in those regions in 2.95+.

Expected Behavior

Constructs synth in these regions

Current Behavior

They don't!

Reproduction Steps

Synth your normal constructs in one of these regions.

Workaround:

Downgrade to 2.94.0 of aws-cdk-lib if encountering this error. Also with this version we added il-central-1 and ap-southeast-4 to CDK Metadata which we don't provide analytical support to and got a patch release out to handle them. The probable solution for that version would be to clean/comment out those two regions from within CDK Metadata and should work.

Solution:

Adding the Kinesis firehose CIDR block for those regions to provide support.
#27672

Related issue:

#27518

Additional Information/Context

Error: Mapping doesn't contain top-level key 'eu-south-2'
    at CfnMapping.findInMap (/workspace/jgstone/UpgradeCDK/src/MyCDK/node_modules/aws-cdk-lib/core/lib/cfn-mapping.js:1:1419)
    at setConnections (/workspace/jgstone/UpgradeCDK/src/MyCDK/node_modules/@aws-cdk/aws-kinesisfirehose-alpha/lib/delivery-stream.ts:407:32)
    at new DeliveryStreamBase (/workspace/jgstone/UpgradeCDK/src/MyCDK/node_modules/@aws-cdk/aws-kinesisfirehose-alpha/lib/delivery-stream.ts:108:24)
    at new DeliveryStream (/workspace/jgstone/UpgradeCDK/src/MyCDK/node_modules/@aws-cdk/aws-kinesisfirehose-alpha/lib/delivery-stream.ts:317:5)
...

CDK CLI Version

2.99.1 (build b2a895e)

Framework Version

No response

Node.js Version

18

OS

MacOS

Language

TypeScript

Language Version

No response

Other information

No response

@jstoneham jstoneham added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 23, 2023
@github-actions github-actions bot added the @aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose label Oct 23, 2023
@jstoneham jstoneham changed the title aws-kinesisfirehose-alpha: 2.95.0 removed support for eu-south-2, ap-south-2 aws-kinesisfirehose-alpha: 2.95.0 removed support for eu-central-2, eu-south-2, ap-south-2 Oct 23, 2023
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 23, 2023
@khushail
Copy link
Contributor

Hi @jstoneham , thanks for reporting this. I will consult with team on why this change was implemented and get back with updates.

@khushail khushail added needs-review p0 and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Oct 24, 2023
@khushail
Copy link
Contributor

@jstoneham , Team is working on this issue and a fix would be provided soon

@jstoneham
Copy link
Author

Thank you for your prompt attention!

@SankyRed
Copy link
Contributor

@jstoneham Working on getting the changes added in for eu-central-2 and ap-south-2. Also wanted to call out that at the moment we do not support eu-south-2(Europe (Spain)). Did check the documentation for the Kinesis Data Firehose CIDR block and seems like we do not support it. Thank you for calling the issue out.

@mergify mergify bot closed this as completed in #27672 Oct 25, 2023
mergify bot pushed a commit that referenced this issue Oct 25, 2023
Closes #27656

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@SankyRed SankyRed self-assigned this Oct 25, 2023
@SankyRed SankyRed added management/tracking Issues that track a subject or multiple issues and removed needs-review labels Oct 25, 2023
@SankyRed SankyRed changed the title aws-kinesisfirehose-alpha: 2.95.0 removed support for eu-central-2, eu-south-2, ap-south-2 ❗ NOTICE: Firehose CIDR block support issue for few regions(eu-central-2, eu-south-2, ap-south-2) Oct 25, 2023
@SankyRed SankyRed pinned this issue Oct 25, 2023
vinayak-kukreja pushed a commit that referenced this issue Oct 25, 2023
Closes #27656

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit to cdklabs/aws-cdk-notices that referenced this issue Oct 25, 2023
mrgrain pushed a commit that referenced this issue Nov 1, 2023
Closes #27656

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@kaizencc kaizencc unpinned this issue Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose bug This issue is a bug. management/tracking Issues that track a subject or multiple issues p0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants