Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(glue): database description property #27744

Merged
merged 7 commits into from
Dec 30, 2023
Merged

feat(glue): database description property #27744

merged 7 commits into from
Dec 30, 2023

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Oct 29, 2023

Closes #27740.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Oct 29, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 29, 2023 22:55
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Oct 29, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 29, 2023
lpizzinidev
lpizzinidev suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
The implementation looks correct, just some adjustments are needed in my opinion.
Can you please add validation for the property according to this?
Also, the title should start with feat(glue): ...

packages/@aws-cdk/aws-glue-alpha/lib/database.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue-alpha/lib/database.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue-alpha/lib/database.ts Outdated Show resolved Hide resolved
@msambol msambol changed the title feat(glue-alpha): add description to database feat(glue): add description to database Oct 30, 2023
@msambol
Copy link
Contributor Author

msambol commented Oct 30, 2023

@lpizzinidev Updated per your recommendations. Thanks!

kaizencc
kaizencc previously approved these changes Oct 30, 2023
View reviewed changes
@kaizencc kaizencc changed the title feat(glue): add description to database feat(glue): database description property Oct 30, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed kaizencc’s stale review October 30, 2023 16:02

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 30, 2023
@msambol msambol requested a review from kaizencc October 30, 2023 21:36
@kaizencc
Copy link
Contributor

@msambol I am good with this PR but I want to throw this by @TheRealAmazonKendra because she is working on Glue changes that may or may not impact this PR.

@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@laurelmay laurelmay mentioned this pull request Nov 3, 2023
Merged
scanlonp
scanlonp previously requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to Kaizen or Kendra's comments:

Should description be a public attribute of the Database class? It is added in the interface but not in the class. Also two very small nits.

Otherwise this looks great! Thank you.

packages/@aws-cdk/aws-glue-alpha/test/database.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue-alpha/lib/database.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 6, 2023
@mergify mergify bot dismissed scanlonp’s stale review November 6, 2023 13:19

Pull request has been modified.

@msambol
Copy link
Contributor Author

msambol commented Nov 6, 2023

Should description be a public attribute of the Database class? It is added in the interface but not in the class. Also two very small nits.

@lpizzinidev mentioned this may not need to be exposed for now. I can add it if necessary.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 6, 2023
@msambol
Copy link
Contributor Author

msambol commented Nov 9, 2023

@TheRealAmazonKendra Can I nudge you for a review here?

@msambol
Copy link
Contributor Author

msambol commented Dec 3, 2023

@kaizencc Could we push this one through?

kaizencc
kaizencc previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Sorry for the delay. Thanks for the review @lpizzinidev. I thought we had some blocker on the glue construct but it's been too long now, and this is an easy win.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 7, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun paulhcsun added the pr/do-not-merge This PR should not be merged at this time. label Dec 8, 2023
@paulhcsun
Copy link
Contributor

Added a pr/do-not-merge tag on this for the time being as there is a group working on a Glue refactor (approved RFC) so we are not currently accepting any Glue PRs. We will push this through as soon as that is completed, we appreciate
your patience @msambol

@natalie-white-aws
Copy link

Per Kendra's request, I reviewed these changes and can confirm that these changes do not conflict with the glue-alpha L2 work in flight. Safe to merge pending all other CDK service team checks without impacting our work.

@TheRealAmazonKendra TheRealAmazonKendra removed the pr/do-not-merge This PR should not be merged at this time. label Dec 15, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@msambol
Copy link
Contributor Author

msambol commented Dec 22, 2023

@kaizencc can we push this through? I think an issue with the queue?

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@mergify mergify bot dismissed kaizencc’s stale review December 28, 2023 18:29

Pull request has been modified.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 021e41c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit cbac240 into aws:main Dec 30, 2023
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@msambol @paulhcsun
feat(glue): database description property (aws#27744)
bdc1c26 
Closes aws#27740.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpizzinidev lpizzinidev lpizzinidev requested changes

@kaizencc kaizencc kaizencc approved these changes

@scanlonp scanlonp scanlonp left review comments

Assignees
No one assigned
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-glue-alpha: Add description to Glue table object
8 participants
@msambol @kaizencc @paulhcsun @natalie-white-aws @aws-cdk-automation @lpizzinidev @scanlonp @TheRealAmazonKendra