chore(prlint): don't mark PRs as 'not ready' on community comment #27819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p2
star-contributor
|
It also seems unnecessary to filter out reviews from the PR author as GitHub already doesn't allow self-approvals or self-requests (though you can comment). Here is what I see on this PR's review tab:
|
laurelmay
force-pushed
the
prlint-labels-community-review
branch
from
3272f1d to
8047429
Compare
Community reviewers have the ability to choose any of the approve/comment/request changes buttons that are available in the review tab. Prior to this change, `prlint` would consider a comment from a community reviewer as being equivalent to requesting changes (and in fact, didn't consider the requesting changes case). This would remove the `pr/needs-community-review` label which surprised some reviewers. With this change, `prlint` will only remove the `pr/needs-community-review` label when a community reviewer specifically chooses "request changes". Additionally, reviewers are now able to switch from approving to requesting changes (this doesn't override any other reviewers' approvals, just that reviewer's own). Additionally, this adds mocks for the `getTrustedCommunityMembers` method and avoids hardcoding the logins of multiple community reviewers into the tests. As a side effect, the tests also run faster since `curl` isn't being invoked so frequently.
laurelmay
force-pushed
the
prlint-labels-community-review
branch
from
8047429 to
1e24d2e
Compare
aws-cdk-automation
added
the
pr/needs-community-review
|
For an example of a community member requesting changes, see #27744 (review). Even though GitHub shows it as "suggested changes", the API |
go-to-k
approved these changes
Nov 7, 2023
aws-cdk-automation
added
pr/needs-maintainer-review
vinayak-kukreja
approved these changes
Nov 8, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mikewrighton
pushed a commit
that referenced
this pull request
Nov 13, 2023
…7819) Community reviewers have the ability to choose any of the approve/comment/request changes buttons that are available in the review tab. Prior to this change, `prlint` would consider a comment from a community reviewer as being equivalent to requesting changes (and in fact, didn't consider the requesting changes case). This would remove the `pr/needs-community-review` label which surprised some reviewers. With this change, `prlint` will only remove the `pr/needs-community-review` label when a community reviewer specifically chooses "request changes". Additionally, reviewers are now able to switch from approving to requesting changes (this doesn't override any other reviewers' approvals, just that reviewer's own). Additionally, this adds mocks for the `getTrustedCommunityMembers` method and avoids hardcoding the logins of multiple community reviewers into the tests. As a side effect, the tests also run faster since `curl` isn't being invoked so frequently. Here is a screenshot of what I see when reviewing on this repo:  ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community reviewers have the ability to choose any of the
approve/comment/request changes buttons that are available in the review
tab. Prior to this change,
prlintwould consider a comment from acommunity reviewer as being equivalent to requesting changes (and in
fact, didn't consider the requesting changes case). This would remove
the
pr/needs-community-reviewlabel which surprised some reviewers.With this change,
prlintwill only remove thepr/needs-community-reviewlabel when a community reviewer specificallychooses "request changes". Additionally, reviewers are now able to
switch from approving to requesting changes (this doesn't override any
other reviewers' approvals, just that reviewer's own).
Additionally, this adds mocks for the
getTrustedCommunityMembersmethod and avoids hardcoding the logins of multiple community reviewers
into the tests. As a side effect, the tests also run faster since
curlisn't being invoked so frequently.
Here is a screenshot of what I see when reviewing on this repo:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license