feat(scheduler-targets-alpha): `InspectorStartAssessmentRun` Target #27850

go-to-k · 2023-11-06T09:45:48Z

This PR adds InspectorStartAssessmentRun Target for EventBridge Scheduler.

In the issue, the inspector.CfnAssessmentTarget is used in the InspectorStartAssessmentRun. But it should be a CfnAssessmentTemplate so I fixed.

  export class InspectorStartAssessmentRun extends ScheduleTargetBase implements IScheduleTarget {
    constructor(
      private readonly target: inspector.CfnAssessmentTarget, // <- here
      private readonly props: ScheduleTargetBaseProps,
    ) {

Closes #27453.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Looks good 👍
Just some minor adjustments in my opinion.

lpizzinidev · 2023-11-06T14:55:15Z

packages/@aws-cdk/aws-scheduler-targets-alpha/lib/inspector-start-assessment-run.ts

+export class InspectorStartAssessmentRun extends ScheduleTargetBase implements IScheduleTarget {
+  constructor(
+    private readonly template: CfnAssessmentTemplate,
+    private readonly props: ScheduleTargetBaseProps,


Suggested change

private readonly props: ScheduleTargetBaseProps,

private readonly props: ScheduleTargetBaseProps = {},

Let's provide a default object to simplify constructor initialization.

lpizzinidev · 2023-11-06T15:01:59Z

packages/@aws-cdk/aws-scheduler-targets-alpha/README.md

@@ -27,6 +27,7 @@ The following targets are supported:
 1. `targets.LambdaInvoke`: [Invoke an AWS Lambda function](#invoke-a-lambda-function))
 2. `targets.StepFunctionsStartExecution`: [Start an AWS Step Function](#start-an-aws-step-function)
 3. `targets.CodeBuildStartBuild`: [Start a CodeBuild job](#start-a-codebuild-job)
+4. `targets.InspectorStartAssessmentRun`: [Start an Amazon Inspector assessment run](#start-an-aws-inspector-assessment-run)


Suggested change

4. `targets.InspectorStartAssessmentRun`: [Start an Amazon Inspector assessment run](#start-an-aws-inspector-assessment-run)

4. `targets.InspectorStartAssessmentRun`: [Start an Amazon Inspector assessment run](#start-an-amazon-inspector-assessment-run)

lpizzinidev · 2023-11-06T15:04:36Z

packages/@aws-cdk/aws-scheduler-targets-alpha/lib/index.ts

@@ -2,3 +2,4 @@ export * from './target';
 export * from './lambda-invoke';
 export * from './stepfunctions-start-execution';
 export * from './codebuild-start-build';
+export * from './inspector-start-assessment-run';


Can you please order these alphabetically?

go-to-k · 2023-11-07T04:34:54Z

@lpizzinidev

Thanks! I changed them.

lpizzinidev

Thanks!
Just some minor adjustment after setting a default value for the props parameter and it will be good to go for me.

lpizzinidev · 2023-11-07T07:16:28Z

packages/@aws-cdk/aws-scheduler-targets-alpha/README.md

+
+new Schedule(this, 'Schedule', {
+  schedule: ScheduleExpression.rate(Duration.minutes(60)),
+  target: new targets.InspectorStartAssessmentRun(assessmentTemplate, {}),


Suggested change

target: new targets.InspectorStartAssessmentRun(assessmentTemplate, {}),

target: new targets.InspectorStartAssessmentRun(assessmentTemplate),

Properties are now optional, let's keep the documentation more concise.

lpizzinidev · 2023-11-07T07:16:56Z

packages/@aws-cdk/aws-scheduler-targets-alpha/test/integ.inspector-start-assessment-run.ts

+
+new scheduler.Schedule(stack, 'Schedule', {
+  schedule: scheduler.ScheduleExpression.rate(cdk.Duration.minutes(10)),
+  target: new InspectorStartAssessmentRun(assessmentTemplate, {}),


Suggested change

target: new InspectorStartAssessmentRun(assessmentTemplate, {}),

target: new InspectorStartAssessmentRun(assessmentTemplate),

lpizzinidev · 2023-11-07T07:18:51Z

packages/@aws-cdk/aws-scheduler-targets-alpha/test/inspector-start-assessment-run.test.ts

+  });
+
+  test('creates IAM role and IAM policy for inspector assessment template in the same account', () => {
+    const inspectorTarget = new InspectorStartAssessmentRun(template, {});


Suggested change

const inspectorTarget = new InspectorStartAssessmentRun(template, {});

const inspectorTarget = new InspectorStartAssessmentRun(template);

Can you please remove the optional parameters here as well? where possible.

go-to-k · 2023-11-07T07:32:44Z

@lpizzinidev

Thanks! I missed the modification. I changed.

lpizzinidev

Thanks 👍

aws-cdk-automation · 2023-11-30T00:09:05Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

…cheduler-targets-inspector

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

vinayak-kukreja

Hey @go-to-k , thank you for this contribution.

I have just updated the ReadMe. I ran the integ test and added the information that helped me running these.

aws-cdk-automation · 2023-11-30T21:00:16Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 2cbb82f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-11-30T21:00:35Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…ws#27850) This PR adds InspectorStartAssessmentRun Target for EventBridge Scheduler. In [the issue](aws#27453), the `inspector.CfnAssessmentTarget` is used in the `InspectorStartAssessmentRun`. But it should be a `CfnAssessmentTemplate` so I fixed. ```ts export class InspectorStartAssessmentRun extends ScheduleTargetBase implements IScheduleTarget { constructor( private readonly target: inspector.CfnAssessmentTarget, // <- here private readonly props: ScheduleTargetBaseProps, ) { ``` Closes aws#27453. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(scheduler-targets): InspectorStartAssessmentRun Target

8d713f8

github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Nov 6, 2023

aws-cdk-automation requested a review from a team November 6, 2023 09:46

aws-cdk-automation previously requested changes Nov 6, 2023

View reviewed changes

change an integ test

1ae40ba

go-to-k marked this pull request as ready for review November 6, 2023 12:13

go-to-k added 2 commits November 6, 2023 21:27

comment in integ

e15ffa1

comment in integ

d6810b6

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 6, 2023

lpizzinidev suggested changes Nov 6, 2023

View reviewed changes

fix for the review

133a802

lpizzinidev suggested changes Nov 7, 2023

View reviewed changes

fix to remove empty object as props

7d2abdd

lpizzinidev approved these changes Nov 7, 2023

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 7, 2023

Merge branch 'main' into feat/scheduler-targets-inspector

9bef18e

go-to-k and others added 4 commits November 30, 2023 17:05

Merge branch 'main' of https://github.com/go-to-k/aws-cdk into feat/s…

bcbde6b

…cheduler-targets-inspector

Update README.md

4cf5364

run integ test and updated the steps

f5c09dd

Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>

Merge branch 'main' into feat/scheduler-targets-inspector

2cbb82f

vinayak-kukreja approved these changes Nov 30, 2023

View reviewed changes

vinayak-kukreja changed the title ~~feat(scheduler-targets): InspectorStartAssessmentRun Target~~ feat(scheduler-targets-alpha): InspectorStartAssessmentRun Target Nov 30, 2023

mergify bot merged commit 073958f into aws:main Nov 30, 2023
14 checks passed

go-to-k deleted the feat/scheduler-targets-inspector branch December 1, 2023 00:56

github-actions bot mentioned this pull request Dec 1, 2023

Monthly PR metrics report - November 2023 #28212

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(scheduler-targets-alpha): `InspectorStartAssessmentRun` Target #27850

feat(scheduler-targets-alpha): `InspectorStartAssessmentRun` Target #27850

go-to-k commented Nov 6, 2023 •

edited

Loading

aws-cdk-automation left a comment

lpizzinidev left a comment

lpizzinidev Nov 6, 2023

lpizzinidev Nov 6, 2023

lpizzinidev Nov 6, 2023

go-to-k commented Nov 7, 2023

lpizzinidev left a comment

lpizzinidev Nov 7, 2023

lpizzinidev Nov 7, 2023

lpizzinidev Nov 7, 2023

go-to-k commented Nov 7, 2023

lpizzinidev left a comment

aws-cdk-automation commented Nov 30, 2023

vinayak-kukreja left a comment

aws-cdk-automation commented Nov 30, 2023

mergify bot commented Nov 30, 2023

	private readonly props: ScheduleTargetBaseProps,
	private readonly props: ScheduleTargetBaseProps = {},

	4. `targets.InspectorStartAssessmentRun`: [Start an Amazon Inspector assessment run](#start-an-aws-inspector-assessment-run)
	4. `targets.InspectorStartAssessmentRun`: [Start an Amazon Inspector assessment run](#start-an-amazon-inspector-assessment-run)

	target: new targets.InspectorStartAssessmentRun(assessmentTemplate, {}),
	target: new targets.InspectorStartAssessmentRun(assessmentTemplate),

	target: new InspectorStartAssessmentRun(assessmentTemplate, {}),
	target: new InspectorStartAssessmentRun(assessmentTemplate),

	const inspectorTarget = new InspectorStartAssessmentRun(template, {});
	const inspectorTarget = new InspectorStartAssessmentRun(template);

feat(scheduler-targets-alpha): InspectorStartAssessmentRun Target #27850

feat(scheduler-targets-alpha): InspectorStartAssessmentRun Target #27850

Conversation

go-to-k commented Nov 6, 2023 • edited Loading

aws-cdk-automation left a comment

Choose a reason for hiding this comment

lpizzinidev left a comment

Choose a reason for hiding this comment

lpizzinidev Nov 6, 2023

Choose a reason for hiding this comment

lpizzinidev Nov 6, 2023

Choose a reason for hiding this comment

lpizzinidev Nov 6, 2023

Choose a reason for hiding this comment

go-to-k commented Nov 7, 2023

lpizzinidev left a comment

Choose a reason for hiding this comment

lpizzinidev Nov 7, 2023

Choose a reason for hiding this comment

lpizzinidev Nov 7, 2023

Choose a reason for hiding this comment

lpizzinidev Nov 7, 2023

Choose a reason for hiding this comment

go-to-k commented Nov 7, 2023

lpizzinidev left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Nov 30, 2023

vinayak-kukreja left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Nov 30, 2023

AWS CodeBuild CI Report

mergify bot commented Nov 30, 2023

feat(scheduler-targets-alpha): `InspectorStartAssessmentRun` Target #27850

feat(scheduler-targets-alpha): `InspectorStartAssessmentRun` Target #27850

go-to-k commented Nov 6, 2023 •

edited

Loading