Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix provided generated Go test #27869

Closed
it-me-joda opened this issue Nov 7, 2023 · 2 comments · Fixed by #27870
Closed

cli: fix provided generated Go test #27869

it-me-joda opened this issue Nov 7, 2023 · 2 comments · Fixed by #27870
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI

Comments

@it-me-joda
Copy link
Contributor

Describe the bug

After creating an application in Go and uncommenting the provided test, the provided test won't run because it is missing an argument.

Expected Behavior

I would expect a test to be able to run as soon as it is uncommented.

Current Behavior

The test failed because not enough arguments in call

Reproduction Steps

  1. cdk init app --language go
  2. Navigate to the _test.go file
  3. Uncomment the file
  4. Attempt to run the tests

Possible Solution

I have forked this for the minor fix.

Additional Information/Context

No response

CDK CLI Version

2.104.0

Framework Version

No response

Node.js Version

20.8.1

OS

Linux - Fedora

Language

Go

Language Version

1.21.3

Other information

No response
@it-me-joda it-me-joda added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 7, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 7, 2023
@it-me-joda it-me-joda mentioned this issue Nov 7, 2023
Merged
@it-me-joda it-me-joda changed the title (module name): (short issue description) cli: fix provided generated Go test Nov 7, 2023
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 7, 2023
@khushail
Copy link
Contributor

khushail commented Nov 7, 2023

Thanks @josephbartley for reporting this and submitting a PR. Appreciate it.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 7, 2023
@mergify mergify bot closed this as completed in #27870 Nov 7, 2023
mergify bot pushed a commit that referenced this issue Nov 7, 2023
@it-me-joda
fix: update commented template test (#27870)
028911f 
Fixes the commented out default test to make it easier for new users to get started. 

Closes #27869.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mikewrighton pushed a commit that referenced this issue Nov 13, 2023
@it-me-joda
fix: update commented template test (#27870)
c6aae60 
Fixes the commented out default test to make it easier for new users to get started. 

Closes #27869.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update commented template test
2 participants
@it-me-joda @khushail