Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DockerImageAsset: Support --no-cache #27916

Closed
2 tasks
austinmw opened this issue Nov 9, 2023 · 3 comments · Fixed by #27944
Closed
2 tasks

DockerImageAsset: Support --no-cache #27916

austinmw opened this issue Nov 9, 2023 · 3 comments · Fixed by #27944
Labels
@aws-cdk/aws-lambda Related to AWS Lambda effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@austinmw
Copy link

austinmw commented Nov 9, 2023

Describe the feature

Currently there's no option to build docker images without caching. The last comment on #20555 explains that this doesn't function as intended.

Use Case

I have a pyproject.toml that requires installing a package from mainline. It currently has no idea if/when mainline has changed and therefore uses cached layers. I need to manually delete local and ECR layers each time to force rebuild.

Proposed Solution

Add ability to pass args that don't take values.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

latest

Environment details (OS name and version, etc.)

MacOS
@austinmw austinmw added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2023
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Nov 9, 2023
@msambol
Copy link
Contributor

msambol commented Nov 9, 2023

I'll take a look here.

@pahud
Copy link
Contributor

pahud commented Nov 10, 2023 •
edited
Loading

Thank you for your report. Looks like there's no workaround out of the box. I'm making it a p1 feature request and we welcome any PRs from the community as well.

@pahud pahud added p1 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 10, 2023
@msambol msambol mentioned this issue Nov 11, 2023
Merged
msambol added a commit to msambol/aws-cdk that referenced this issue Nov 11, 2023
@msambol
Merge branch 'main' into awsgh-27916
4a68892
@github-actions github-actions bot mentioned this issue Dec 1, 2023
Closed
kaizencc added a commit to msambol/aws-cdk that referenced this issue Dec 23, 2023
@kaizencc
Merge branch 'main' into awsgh-27916
94a8380
mergify bot added a commit to msambol/aws-cdk that referenced this issue Dec 23, 2023
@mergify
Merge branch 'main' into awsgh-27916
ab10677
@mergify mergify bot closed this as completed in #27944 Dec 23, 2023
mergify bot pushed a commit that referenced this issue Dec 23, 2023
@msambol
feat(core): option to disable cache for docker build (#27944)
84d81b6 
Closes #27916.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
@msambol @paulhcsun
feat(core): option to disable cache for docker build (aws#27944)
cd1c1ed 
Closes aws#27916.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-lambda Related to AWS Lambda effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): option to disable cache for docker build msambol/aws-cdk
3 participants
@pahud @msambol @austinmw