Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): option to disable cache for docker build #27944

Merged
merged 6 commits into from
Dec 23, 2023
Merged

feat(core): option to disable cache for docker build #27944

merged 6 commits into from
Dec 23, 2023

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Nov 11, 2023

Closes #27916.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Nov 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 11, 2023 03:56
@msambol
Copy link
Contributor Author

msambol commented Nov 11, 2023

This touches a few different packages.. I put feat(core) but let me know if that's not right.

aws-cdk-automation
aws-cdk-automation previously requested changes Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@msambol msambol marked this pull request as draft November 11, 2023 04:43
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 11, 2023 19:51

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@msambol msambol marked this pull request as ready for review November 11, 2023 21:01
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 11, 2023
@msambol msambol changed the title feat(core): add --no-cache option for docker build feat(core): add cache disabled option for docker build Nov 11, 2023
@msambol msambol changed the title feat(core): add cache disabled option for docker build feat(core): add option to disable cache for docker build Nov 12, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

1 similar comment
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation
aws-cdk-automation previously requested changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 3, 2023 22:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@msambol
Copy link
Contributor Author

msambol commented Dec 13, 2023

@lpizzinidev Could I get poke you for a review here? 😄

lpizzinidev
lpizzinidev suggested changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
I left some minor suggestions for increasing test coverage.

packages/aws-cdk-lib/core/lib/assets.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a test here for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added 👍🏼

packages/aws-cdk-lib/cx-api/lib/assets.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a test here for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added 👍🏼

@msambol
Copy link
Contributor Author

msambol commented Dec 14, 2023

@lpizzinidev Updated with your feedback 👍🏼

@kaizencc kaizencc changed the title feat(core): add option to disable cache for docker build feat(core): option to disable cache for docker build Dec 22, 2023
kaizencc
kaizencc approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msambol

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 22, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ab10677
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 84d81b6 into aws:main Dec 23, 2023
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@msambol @paulhcsun
feat(core): option to disable cache for docker build (aws#27944)
cd1c1ed 
Closes aws#27916.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DockerImageAsset: Support --no-cache
4 participants
@msambol @aws-cdk-automation @lpizzinidev @kaizencc