Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globalaccelerator: ip addresses attribute from the Accelerator construct #28051

Closed
2 tasks
werebear73 opened this issue Nov 17, 2023 · 3 comments · Fixed by #28055
Closed
2 tasks

globalaccelerator: ip addresses attribute from the Accelerator construct #28051

werebear73 opened this issue Nov 17, 2023 · 3 comments · Fixed by #28055
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@werebear73
Copy link

Describe the feature

It would be helpful to have the public IP addresses associated with the Accelerator (Global Accelerator) available as properties during stack definition.

Use Case

As some of applications 3rd party and internally built may require firewall or open port setting requiring the public IP address in configuration, this property (IPAddresses) would be useful. I haven't found another way (Fn:GetAttr) to be able to get this information easily.

Proposed Solution

The addition of a read only property of the Accelerator object named something similar to IPAddresses that lists the 2 IP Addresses for the Accelerator object

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.106.0

Environment details (OS name and version, etc.)

Windows 11, Visual Studio 2022 Community Edition, .Net 6

@werebear73 werebear73 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 17, 2023
@pahud
Copy link
Contributor

pahud commented Nov 17, 2023

Yes, we should expose that to the L2 attributes and we welcome any any pull request from the community.

For now, you can work it around with this

  const myga = new ga.Accelerator(this, 'GA');
  const cfnAccelerator = myga.node.tryFindChild('Resource') as ga.CfnAccelerator
  cfnAccelerator.attrIpv4Addresses // the IPv4 addresses

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 17, 2023
@pahud pahud changed the title (module name): (short issue description) globalaccelerator: ip addresses attribute from the Accelerator construct Nov 17, 2023
@msambol
Copy link
Contributor

msambol commented Nov 17, 2023

I'll take this.

msambol added a commit to msambol/aws-cdk that referenced this issue Nov 20, 2023
msambol added a commit to msambol/aws-cdk that referenced this issue Dec 3, 2023
mergify bot added a commit to msambol/aws-cdk that referenced this issue Dec 21, 2023
@mergify mergify bot closed this as completed in #28055 Dec 21, 2023
mergify bot pushed a commit that referenced this issue Dec 21, 2023
Closes #28051, #28209.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
…8055)

Closes aws#28051, aws#28209.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants