Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for monitoring to RDS DatabaseCluster #2826

Closed
rpanfili opened this issue Jun 11, 2019 · 1 comment · Fixed by #2828
Closed

Add support for monitoring to RDS DatabaseCluster #2826

rpanfili opened this issue Jun 11, 2019 · 1 comment · Fixed by #2828
Assignees
@skinny85
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@rpanfili
Copy link
Contributor

At the moment is not possible to specify any monitoring configuration on DatabaseCluster instances. This kind of feature would improve ops capabilities. Ideally it have to be possible to specify a monitoringInterval and auto-generate a valid Role to manage it.
@rpanfili rpanfili added the feature-request A feature should be added or improved. label Jun 11, 2019
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 11, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
aaa069d 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringInterval`

closes aws#2826
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 11, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
2be9288 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringInterval`

closes aws#2826
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 11, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
64c66a4 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringInterval`

closes aws#2826
@rpanfili rpanfili mentioned this issue Jun 11, 2019
Merged
4 tasks
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 14, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
b3a5d57 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 17, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
493c3d8 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
@NGL321 NGL321 added the needs-triage This issue or PR still needs to be triaged. label Jun 17, 2019
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 17, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
8ef269c 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 17, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
c87b458 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 17, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
b053c09 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
10e85ca 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
4a2ed35 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
8357ff1 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
488384d 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
0b427f4 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
a5875f7 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
b5e78f4 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
ce1726d 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
6e626c5 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826

BREAKING CHANGE:
* rds: `monitoringInterval` in `DatabaseInstanceNewProps` has been renamed to `monitoringIntervalSec`
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 21, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
b66544c 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringIntervalSec`

closes aws#2826
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 21, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
90530f9 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringInterval`

closes aws#2826
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 24, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
9199027 
Lets a user specify a monitoring interval period. This change will also
auto-generate a valid Role to manage DB instances monitoring.

This change adds an optional prop `monitoringInterval`

closes aws#2826
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Sep 11, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
f10504c 
Let a user define a monitoring interval period. It will be
also possible to specify a monitoring IAM Role to manage instances
monitoring, otherwise a valid Role will be auto-generated.

This change adds optional props `monitoringInterval` and `monitoringRole`

closes aws#2826
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Sep 11, 2019
@rpanfili
feat(rds): add support for monitoring to database cluster
06f1bdb 
Let a user define a monitoring interval period. It will be
also possible to specify a monitoring IAM Role to manage instances
monitoring, otherwise a valid Role will be auto-generated.

This change adds optional props `monitoringInterval` and `monitoringRole`
to `DatabaseClusterProps` and optional `monitoringRole` to
`DatabaseInstanceProps`

closes aws#2826
@zxkane
Copy link
Contributor

zxkane commented Sep 12, 2019

Still missing some cloudwatch log settings in cluster's properties, such as cloudwatchLogsExports. Having to use low level of CfnDBCluster archives the log setting as a workaround.

@mergify mergify bot closed this as completed in #2828 Oct 3, 2019
mergify bot pushed a commit that referenced this issue Oct 3, 2019
@rpanfili @mergify
feat(rds): add support for monitoring to database cluster (#2828)
910c8bf 
Let a user define a monitoring interval period. It will be
also possible to specify a monitoring IAM Role to manage instances
monitoring, otherwise a valid Role will be auto-generated.

This change adds optional props `monitoringInterval` and `monitoringRole`
to `DatabaseClusterProps` and optional `monitoringRole` to
`DatabaseInstanceProps`

closes #2826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rds): add support for monitoring to DatabaseCluster rpanfili/aws-cdk
4 participants
@skinny85 @zxkane @rpanfili @NGL321