-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(custom-resources): cannot set logging for state machine generated in CompleteHandler #28706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
…epfunctions-tasks-emr-containers-start-job-run-integ
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
✅ Branch has been successfully updated |
@mergify update |
✅ Branch has been successfully updated |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@Mergifyio update |
☑️ Nothing to do
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR fixes the case that
StateMachine
generated forCompleteHandler
inProvider
cannot set logging.The default log group name of the state machine automatically created by the
Provider
withisCompleteHandler
should start with/aws/vendedlogs/states
. Otherwise, each time the state machine is created, the log resource policy size increases.https://docs.aws.amazon.com/step-functions/latest/dg/bp-cwl.html
Closes #27283
Fixes #28577 #28744
Related PR #27310(reverted by #28699), #28587
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license