-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: diff --change-set flag not configurable via cdk.json #29232
Comments
Piggy backing on this issue to request that the log message be suppressed if the flag is configured explicitly in |
I'm happy to try and solve this myself if someone points me in the right direction. I took a quick look at the code however it's not immediately obvious how/where these flags are passed through via the |
Opened #29375 with some changes for this. |
Describe the bug
A new flag was introduced as part of #28336
This flag doesn't seem to be set to wanted default value using the cdk.json.
There's also missing documentation about this flag in the CLI reference. Arguably a different issue since it'll be a different repo? I'm not sure how to report that. Feel free to point me in the right direction.
Expected Behavior
Ability to override default value in
cdk.json
Current Behavior
Anything set in in the
cdk.json
will be ignoredReproduction Steps
change-set
flag incdk.json
to falseexpected: warning message above dissapears
actual: still seeing the warning (behaviour hasn't changed)
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.128.0
Framework Version
No response
Node.js Version
v20.11.1
OS
darwin ARM64
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: