Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pipes-enrichments): Add Step Functions state machine enrichment for EventBridge pipes #29385

Closed
2 tasks
RaphaelManke opened this issue Mar 6, 2024 · 2 comments · Fixed by #30495, codu-code/codu#969 or rwlxxvii/containers#185 · May be fixed by NOUIY/aws-solutions-constructs#112 or gitafolabi/kreuzlaker#2
Closed
2 tasks

(pipes-enrichments): Add Step Functions state machine enrichment for EventBridge pipes #29385

RaphaelManke opened this issue Mar 6, 2024 · 2 comments · Fixed by #30495, codu-code/codu#969 or rwlxxvii/containers#185 · May be fixed by NOUIY/aws-solutions-constructs#112 or gitafolabi/kreuzlaker#2
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@RaphaelManke
Copy link
Contributor

Describe the feature

Add a implementation for the Step Functions state machine enrichment for EventBridge pipes in the pipes-enrichment module.

Use Case

For feature completeness of the L2 pipes module this source is required.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

Environment details (OS name and version, etc.)
@RaphaelManke RaphaelManke added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 6, 2024
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Mar 6, 2024
@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 6, 2024
@mrgrain mrgrain added @aws-cdk/aws-events Related to CloudWatch Events and removed @aws-cdk/aws-lambda Related to AWS Lambda labels Mar 7, 2024
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
@mazyu36 mazyu36 mentioned this issue Jun 9, 2024
Merged
1 task
@mergify mergify bot closed this as completed in #30495 Jun 21, 2024
@mergify mergify bot closed this as completed in 8b495f9 Jun 21, 2024
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

sarangarav pushed a commit to sarangarav/aws-cdk that referenced this issue Jun 21, 2024
@mazyu36
feat(pipes-enrichments): add Step Functions enrichment eventbridge pi…
8ccc4b3 
…pes (aws#30495)

### Issue # (if applicable)

Closes aws#29385.

### Reason for this change
To use Step Functions state machine enrichment for eventbrige pipes

### Description of changes
Add `StepFunctionsEnrichment` class.

### Description of how you validated changes
Add unit test and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 added a commit to mazyu36/aws-cdk that referenced this issue Jun 22, 2024
@mazyu36
feat(pipes-enrichments): add Step Functions enrichment eventbridge pi…
22e4edd 
…pes (aws#30495)

### Issue # (if applicable)

Closes aws#29385.

### Reason for this change
To use Step Functions state machine enrichment for eventbrige pipes



### Description of changes
Add `StepFunctionsEnrichment` class.



### Description of how you validated changes
Add unit test and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@NiallJoeMaher NiallJoeMaher mentioned this issue Jul 29, 2024
Merged
@NOUIY NOUIY mentioned this issue Aug 1, 2024
Open
@NiallJoeMaher NiallJoeMaher mentioned this issue Aug 12, 2024
Closed
@gitafolabi gitafolabi mentioned this issue Aug 16, 2024
Open
@NOUIY NOUIY mentioned this issue Aug 20, 2024
Open
@NOUIY NOUIY mentioned this issue Sep 5, 2024
Open
This was referenced Sep 5, 2024
Closed
Closed
@rwlxxvii rwlxxvii mentioned this issue Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@pahud @mrgrain @RaphaelManke