Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add an existing security group to a RDS database #2949

Closed
repolevedavaj opened this issue Jun 20, 2019 · 4 comments · Fixed by #4495
Closed

Ability to add an existing security group to a RDS database #2949

repolevedavaj opened this issue Jun 20, 2019 · 4 comments · Fixed by #4495
Assignees
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@repolevedavaj
Copy link

I noticed that some configuration options which are available when creating a RDS database (e.g. MySQL) in the console, are not available if creating one with CDK.

Options which are currently not available (in version 0.35):

  • Adding an existing security group
  • Configure public accessibility
  • Configure enhanced monitoring

(I am sure this list is not complete)

@repolevedavaj repolevedavaj added the feature-request A feature should be added or improved. label Jun 20, 2019
@jogold
Copy link
Contributor

jogold commented Jun 20, 2019

Configure public accessibility: this is automatically determined based on the type of subnets specified in vpcPlacement, your instance will be publicly accessible if those are of the type SubnetType.Public

Configure enhanced monitoring: setting monitoringInterval to a value > 0 will enable it.

You are right about the existing security group but note that you can use the connections object of the created instance to add ingress/egress rules.

@repolevedavaj
Copy link
Author

Thanks for your quick advice. I will change my setup accordingly. Should I close the issue or should I rename it to something like "Ability to add an existing security group to a RDS database"?

@jogold
Copy link
Contributor

jogold commented Jun 21, 2019

Rename it

@NGL321 NGL321 added the @aws-cdk/aws-rds Related to Amazon Relational Database label Jun 21, 2019
@NGL321 NGL321 changed the title Complete configuration options for RDS database creation Ability to add an existing security group to a RDS database Jun 21, 2019
@NGL321
Copy link
Contributor

NGL321 commented Jun 21, 2019

@repolevedavaj thank you so much for bringing this to our attention!
We are working hard to stabilize the CDK APIs and tuning them to meet our consistency guidelines. While we work on getting the APIs aligned with our guidelines, we are pausing work on most community PRs and feature-requests starting today. Please continue to report issues and submit feature requests, of course. We expect to get back to work on community PRs within a few weeks.

A team member will update this issue when we are able to address it.

@skinny85 skinny85 self-assigned this Aug 12, 2019
jogold added a commit to jogold/aws-cdk that referenced this issue Oct 14, 2019
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 14, 2019
@mergify mergify bot closed this as completed in #4495 Oct 24, 2019
mergify bot pushed a commit that referenced this issue Oct 24, 2019
* feat(rds): allow using existing security group for instance

Closes #2949

* securityGroups

* s

* avoid duplication

* remove useless protected securityGroups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants