Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ec2: InterfaceVpcEndpointAwsService not supported for bedrock-runtime and bedrock #29523

Closed
2 tasks
clouddev-code opened this issue Mar 17, 2024 · 2 comments · Fixed by #29524
Closed
2 tasks

aws_ec2: InterfaceVpcEndpointAwsService not supported for bedrock-runtime and bedrock #29523

clouddev-code opened this issue Mar 17, 2024 · 2 comments · Fixed by #29524
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@clouddev-code
Copy link

Describe the feature

by InterfaceVpcEndpointAwsServiceçe not supported for bedrock-runtime and bedrock
https://docs.aws.amazon.com/bedrock/latest/userguide/usingVPC.html

Use Case

I want to crate interface endpoint by AWS CDK

Proposed Solution

Could easily be accomplished by adding variables by the foolowing code
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts

Other Information

static readonly defintion add
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.133.0

Environment details (OS name and version, etc.)

M1 mac
@clouddev-code clouddev-code added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 17, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Mar 17, 2024
@msambol msambol mentioned this issue Mar 18, 2024
Merged
@github-actions github-actions bot mentioned this issue Mar 18, 2024
Closed
@tim-finnigan tim-finnigan self-assigned this Mar 18, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 18, 2024
@tim-finnigan
Copy link

Thanks for the feature request. It looks like a PR (#29524) was created to address this.

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 18, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 18, 2024
@mergify mergify bot closed this as completed in #29524 Mar 21, 2024
mergify bot pushed a commit that referenced this issue Mar 21, 2024
@msambol
chore(ec2): add missing vpc endpoints (#29524)
f63656e 
I used [this doc](https://docs.aws.amazon.com/vpc/latest/privatelink/aws-services-privatelink-support.html) for the "friendly" names and tried to make them as close as possible to the AWS service names.

Closes #29523.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

jun1-t pushed a commit to jun1-t/aws-cdk that referenced this issue Mar 23, 2024
@msambol @jun1-t
chore(ec2): add missing vpc endpoints (aws#29524)
14f3e77 
I used [this doc](https://docs.aws.amazon.com/vpc/latest/privatelink/aws-services-privatelink-support.html) for the "friendly" names and tried to make them as close as possible to the AWS service names.

Closes aws#29523.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
ahammond pushed a commit to ahammond/aws-cdk that referenced this issue Mar 26, 2024
@msambol @ahammond
chore(ec2): add missing vpc endpoints (aws#29524)
76bd51f 
I used [this doc](https://docs.aws.amazon.com/vpc/latest/privatelink/aws-services-privatelink-support.html) for the "friendly" names and tried to make them as close as possible to the AWS service names.

Closes aws#29523.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ec2): add missing vpc endpoints msambol/aws-cdk
2 participants
@clouddev-code @tim-finnigan