Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sns: Support for SignatureVersion #29539

Closed
1 of 2 tasks
jun1-t opened this issue Mar 19, 2024 · 3 comments · Fixed by #29543 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@jun1-t
Copy link
Contributor

jun1-t commented Mar 19, 2024

Describe the feature

Enable setting of SignatureVersion in the L2 construct for SNS topics.

https://docs.aws.amazon.com/sns/latest/dg/sns-verify-signature-of-message.html

Use Case

To set the SignatureVersion, it is necessary to configure it via L1.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-sns-topic.html#cfn-sns-topic-signatureversion

Proposed Solution

Allows passing the "SigantureVersion" parameter as an argument.

const topic = new sns.Topic(this, 'MyTopic', {
  signatureVersion: '1',
});

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.133.0

Environment details (OS name and version, etc.)

irrelevant

@jun1-t jun1-t added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 19, 2024
@github-actions github-actions bot added the @aws-cdk/aws-sns Related to Amazon Simple Notification Service label Mar 19, 2024
@tim-finnigan tim-finnigan self-assigned this Mar 19, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 19, 2024
@tim-finnigan
Copy link

tim-finnigan commented Mar 19, 2024

Hi @jun1-t thanks for the feature request and we would appreciate any pull request. As a current workaround here is the CfnTopic signatureVersion documentation: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_sns.CfnTopic.html#signatureversion

@tim-finnigan tim-finnigan added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 19, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 19, 2024
@pahud
Copy link
Contributor

pahud commented Mar 19, 2024

Hi @jun1-t

Yes this would be great to include that in the L2 props. Welcome and appreciate your pull request. Let me know if you need any help.

@pahud pahud removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Mar 19, 2024
@mergify mergify bot closed this as completed in #29543 Mar 29, 2024
mergify bot pushed a commit that referenced this issue Mar 29, 2024
Closes #29539. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
3 participants