Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pipes): Add EventBridge Pipes event delivery VPC Endpoint Service #30015

Closed
1 of 2 tasks
Liversticks opened this issue Apr 30, 2024 · 3 comments · Fixed by #30246
Closed
1 of 2 tasks

(pipes): Add EventBridge Pipes event delivery VPC Endpoint Service #30015

Liversticks opened this issue Apr 30, 2024 · 3 comments · Fixed by #30246
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@Liversticks
Copy link
Contributor

Describe the feature

https://aws.amazon.com/about-aws/whats-new/2024/04/amazon-eventbridge-pipes-event-delivery-aws-privatelink/

EventBridge Pipes recently launched support to deliver events through AWS PrivateLink.

Use Case

This is an official AWS service so we think it would be nice to include it with the other AWS services.

Proposed Solution

Modify

aws-cdk/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts

Line 274 in 4f1c94b

export class InterfaceVpcEndpointAwsService implements IInterfaceVpcEndpointService {
, add pipes-data AWS VPC Endpoint Service

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

Environment details (OS name and version, etc.)

all
@Liversticks Liversticks added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 30, 2024
@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label Apr 30, 2024
@github-actions github-actions bot mentioned this issue May 1, 2024
Closed
@Liversticks Liversticks mentioned this issue May 1, 2024
Closed
@khushail
Copy link
Contributor

khushail commented May 1, 2024

thanks @Liversticks for requesting this feature. Please feel free to refer to this Contributing guide to get started.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 1, 2024
This was referenced May 6, 2024
Closed
Closed
@Liversticks Liversticks mentioned this issue May 16, 2024
Merged
@mergify mergify bot closed this as completed in #30246 May 29, 2024
mergify bot pushed a commit that referenced this issue May 29, 2024
@Liversticks
chore(ec2): eventbridge pipes pipes-data vpc endpoint (#30246)
d27de72 
### Issue # (if applicable)

Closes #30015 .

### Reason for this change

Same as #30033, but done with `chore` instead of `feat`.

> EventBridge Pipes recently added PrivateLink support for event delivery [(what's new)](https://aws.amazon.com/about-aws/whats-new/2024/04/amazon-eventbridge-pipes-event-delivery-aws-privatelink/). The VPC Endpoint Service name is com.amazonaws.{region}.pipes-data [(source)](https://docs.aws.amazon.com/vpc/latest/privatelink/aws-services-privatelink-support.html). 

### Description of changes

Added pipes-data VPC endpoint construct. By adding this construct in a VPC, I can send Amazon MSK, self-managed Apache Kafka, and Amazon MQ events to EventBridge Pipes through PrivateLink.

### Description of how you validated changes

N/A

### Checklist
- [ X ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

atanaspam pushed a commit to atanaspam/aws-cdk that referenced this issue Jun 3, 2024
@Liversticks @atanaspam
chore(ec2): eventbridge pipes pipes-data vpc endpoint (aws#30246)
f1ef028 
### Issue # (if applicable)

Closes aws#30015 .

### Reason for this change

Same as aws#30033, but done with `chore` instead of `feat`.

> EventBridge Pipes recently added PrivateLink support for event delivery [(what's new)](https://aws.amazon.com/about-aws/whats-new/2024/04/amazon-eventbridge-pipes-event-delivery-aws-privatelink/). The VPC Endpoint Service name is com.amazonaws.{region}.pipes-data [(source)](https://docs.aws.amazon.com/vpc/latest/privatelink/aws-services-privatelink-support.html). 

### Description of changes

Added pipes-data VPC endpoint construct. By adding this construct in a VPC, I can send Amazon MSK, self-managed Apache Kafka, and Amazon MQ events to EventBridge Pipes through PrivateLink.

### Description of how you validated changes

N/A

### Checklist
- [ X ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this issue Jun 10, 2024
@Liversticks
chore(ec2): eventbridge pipes pipes-data vpc endpoint (aws#30246)
06a6705 
### Issue # (if applicable)

Closes aws#30015 .

### Reason for this change

Same as aws#30033, but done with `chore` instead of `feat`.

> EventBridge Pipes recently added PrivateLink support for event delivery [(what's new)](https://aws.amazon.com/about-aws/whats-new/2024/04/amazon-eventbridge-pipes-event-delivery-aws-privatelink/). The VPC Endpoint Service name is com.amazonaws.{region}.pipes-data [(source)](https://docs.aws.amazon.com/vpc/latest/privatelink/aws-services-privatelink-support.html). 

### Description of changes

Added pipes-data VPC endpoint construct. By adding this construct in a VPC, I can send Amazon MSK, self-managed Apache Kafka, and Amazon MQ events to EventBridge Pipes through PrivateLink.

### Description of how you validated changes

N/A

### Checklist
- [ X ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@aws-cdk-automation @Liversticks @khushail