Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI ignores profile in cdk.json #3007

Closed
1 of 5 tasks
prencher opened this issue Jun 21, 2019 · 4 comments · Fixed by #7398
Closed
1 of 5 tasks

CLI ignores profile in cdk.json #3007

prencher opened this issue Jun 21, 2019 · 4 comments · Fixed by #7398
Assignees
@shivlaks
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort in-progress This issue is being actively worked on. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@prencher
Copy link

prencher commented Jun 21, 2019 •
edited
Loading

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.

  • What is the current behavior?
    If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce

When you specify profile in cdk.json, it's ignored.

  • What is the expected behavior (or behavior of feature suggested)?

profile key is respected.

  • What is the motivation / use case for changing the behavior or adding this feature?

Having reasonable defaults for a project. The ultimate ideal would be per-env credentials but we're using multiple cdk.json files (one per account) as a stopgap.

  • Please tell us about your environment:

    • CDK CLI Version: 0.35.0
    • Module Version: 0.35.0
    • OS: macOS Mojave
    • Language: TypeScript
@prencher prencher mentioned this issue Jun 21, 2019
Closed
5 tasks
@rix0rrr rix0rrr added feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI labels Jun 26, 2019
@boricic
Copy link

boricic commented Jul 25, 2019

I've experienced the same issue. Following this I was under the impression that adding profile to cdk.json should work, but it doesn't.

If that worked, for me that would be a major improvement since I have multiple profiles I currently have to specify --profile option with every cli command.

@eladb eladb assigned shivlaks and unassigned shivlaks Aug 12, 2019
@shivlaks shivlaks added effort/medium Medium work item – several days of effort bug This issue is a bug. p2 and removed feature-request A feature should be added or improved. labels Feb 5, 2020
@shivlaks
Copy link
Contributor

shivlaks commented Feb 5, 2020

@prencher @boricic - I don't believe we support all the switches in cdk.json and we should. tagging this as a bug

@itoyama itoyama mentioned this issue Apr 17, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Apr 20, 2020
@mergify mergify bot closed this as completed in #7398 Apr 29, 2020
mergify bot pushed a commit that referenced this issue Apr 29, 2020
@itoyama
fix(cli): CLI ignores profile in cdk.json (#7398)
6784dc3 
The profile option was not being passed from cdk.json.

Get the values from the merged configuration, instead of using the profile argument directly.

Closes #3007
@roll
Copy link

roll commented Apr 30, 2020

Hi, thanks for solving it!

Is it a part of 1.36.1? The ckd.json->profile still doesn't seem to affect my npx cdk calls

@shivlaks
Copy link
Contributor

Hi, thanks for solving it!

Is it a part of 1.36.1? The ckd.json->profile still doesn't seem to affect my npx cdk calls

it will be included in the next release (likely 1.37.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort in-progress This issue is being actively worked on. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): CLI ignores profile in cdk.json
6 participants
@prencher @rix0rrr @roll @boricic @SomayaB @shivlaks