Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds: integ tests fail to deploy due to using deprecated postgres version #30131

Closed
paulhcsun opened this issue May 9, 2024 · 5 comments · Fixed by #30219
Closed

rds: integ tests fail to deploy due to using deprecated postgres version #30131

paulhcsun opened this issue May 9, 2024 · 5 comments · Fixed by #30219
Assignees
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@paulhcsun
Copy link
Contributor

Describe the bug

Some existing integ tests within the aws-rds module fail to deploy because they were created with a postgres version that is now deprecated (version <=15.x) and fails with the following error

"Cannot find version 15.2 for postgres (Service: Rds, Status Code: 400, Request ID: 3aaada49-96f7-42bc-ae49-3674c11f56df)"

This is due to the existing snapshots already using the deprecated versions.

Expected Behavior

Should be able to deploy the integ test successfully.

Current Behavior

Fails with the following error

"Cannot find version 15.2 for postgres (Service: Rds, Status Code: 400, Request ID: 3aaada49-96f7-42bc-ae49-3674c11f56df)"

Reproduction Steps

Deploy one of the aws-rds integ tests that still uses a deprecated version of postgres (<=15.x).
i.e.

const parameterGroup = new rds.ParameterGroup(stack, 'ParameterGroup', {
  engine: rds.DatabaseInstanceEngine.postgres({ version: rds.PostgresEngineVersion.VER_15_2 }),
  ...
});

Possible Solution

The solution is to manually delete the corresponding snapshot folder for these tests and update the postgres version to a supported version (currently >=16.x) and rerun the integ test to generate the new snapshots.

Additional Information/Context

No response

CDK CLI Version

2.141.0

Framework Version

No response

Node.js Version

v21.7.1

OS

14.4.1

Language

TypeScript

Language Version

No response

Other information

No response

@paulhcsun paulhcsun added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 9, 2024
@paulhcsun paulhcsun self-assigned this May 9, 2024
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label May 9, 2024
@paulhcsun paulhcsun added p2 effort/small Small work item – less than a day of effort and removed @aws-cdk/aws-rds Related to Amazon Relational Database needs-triage This issue or PR still needs to be triaged. labels May 9, 2024
@daschaa
Copy link
Contributor

daschaa commented May 14, 2024

I would like to take this issue :)

@Leo10Gama
Copy link
Member

@daschaa Thanks for your interest! However, we have someone actively working on this already.

@daschaa
Copy link
Contributor

daschaa commented May 14, 2024

@Leo10Gama Oh that's unfortunate. Thanks for letting me know.

mergify bot pushed a commit that referenced this issue May 15, 2024
### Issue # (if applicable)

Closes #30131 

### Reason for this change

Postgres version 15.2 is deprecated.

### Description of changes

Any and all references to Postgres 15.2 now reference 16.2 instead.

### Description of how you validated changes

Ran all changed integ and unit tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mergify mergify bot closed this as completed in #30219 May 15, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

atanaspam pushed a commit to atanaspam/aws-cdk that referenced this issue Jun 3, 2024
### Issue # (if applicable)

Closes aws#30131 

### Reason for this change

Postgres version 15.2 is deprecated.

### Description of changes

Any and all references to Postgres 15.2 now reference 16.2 instead.

### Description of how you validated changes

Ran all changed integ and unit tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
4 participants