Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(rds): certificate enum values misspelled #30132

Closed
scanlonp opened this issue May 9, 2024 · 2 comments · Fixed by #30135
Closed

(rds): certificate enum values misspelled #30132

scanlonp opened this issue May 9, 2024 · 2 comments · Fixed by #30135
Assignees
@scanlonp
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@scanlonp
Copy link
Contributor

scanlonp commented May 9, 2024 •
edited
Loading

Describe the bug

As mentioned in this comment, enum names have a typo, see ca-certificate.ts.

This will be a breaking change to update directly, so we add the corrected spelling and optionally deprecate the values with the typos.
@scanlonp scanlonp added bug This issue is a bug. p2 @aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort labels May 9, 2024
@scanlonp scanlonp self-assigned this May 9, 2024
@scanlonp scanlonp changed the title (RDS): caCertificate enum values mis-spelled (RDS): caCertificate enum values misspelled May 9, 2024
@scanlonp scanlonp changed the title (RDS): caCertificate enum values misspelled (rds): caCertificate enum values misspelled May 9, 2024
@scanlonp scanlonp changed the title (rds): caCertificate enum values misspelled (rds): certificate enum values misspelled May 9, 2024
@scanlonp scanlonp mentioned this issue May 9, 2024
Merged
@mergify mergify bot closed this as completed in #30135 May 10, 2024
mergify bot pushed a commit that referenced this issue May 10, 2024
@scanlonp
chore(rds): fix certificate enum values misspelling (#30135)
495204f 
Closes #30132

### Reason for this change

Slight misspelling of enum values.

### Description of changes

Fixed the name. Deprecated the old values. Changed values in tests & readmes

### Description of how you validated changes

No behavior change as underlying value is the same.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced May 13, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@scanlonp scanlonp

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rds): fix certificate enum values misspelling scanlonp/aws-cdk
2 participants
@aws-cdk-automation @scanlonp