Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all enum-like members to all-caps (same as normal enums) #3018

Closed
eladb opened this issue Jun 23, 2019 · 0 comments · Fixed by #3023
Closed

Rename all enum-like members to all-caps (same as normal enums) #3018

eladb opened this issue Jun 23, 2019 · 0 comments · Fixed by #3023

Comments

@eladb
Copy link
Contributor

eladb commented Jun 23, 2019

No description provided.

shivlaks added a commit that referenced this issue Jun 24, 2019
Similar to the enum naming convention, public static readonly properties
must be ALL_CAPS.

This is in accordance with the new construct library guidelines.

Fixes #3018

BREAKING CHANGE: members in enum like classes are now named using ALL_CAPS
eladb pushed a commit that referenced this issue Jun 24, 2019
Similar to the enum naming convention, public static readonly properties
must be ALL_CAPS.

This is in accordance with the new construct library guidelines and with normal enums.

Fixes #3018
Fixes #980

BREAKING CHANGE: all public static readonly members (enum-like) have been renamed to use "ALL_CAPS" capitalization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants