Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2: support placementGroupName for ec2.Instance #30292

Closed
1 of 2 tasks
pahud opened this issue May 21, 2024 · 2 comments · Fixed by #30293 or rwlxxvii/containers#140 · May be fixed by NOUIY/aws-solutions-constructs#103, Opetushallitus/heratepalvelu#280 or NOUIY/aws-solutions-constructs#104
Closed
1 of 2 tasks

ec2: support placementGroupName for ec2.Instance #30292

pahud opened this issue May 21, 2024 · 2 comments · Fixed by #30293 or rwlxxvii/containers#140 · May be fixed by NOUIY/aws-solutions-constructs#103, Opetushallitus/heratepalvelu#280 or NOUIY/aws-solutions-constructs#104
Assignees
@pahud
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@pahud
Copy link
Contributor

pahud commented May 21, 2024 •
edited
Loading

Describe the feature

allow ec2.Instance to specify placementGroupName, which is available in L1.

Use Case

ec2 instance placement group support
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/placement-groups.html

Proposed Solution

expose the L1 prop to the surface

Other Information

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-instance.html#cfn-ec2-instance-placementgroupname

#11331 (comment)

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

all

Environment details (OS name and version, etc.)

all
@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 21, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label May 21, 2024
@pahud pahud added p2 effort/medium Medium work item – several days of effort @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud and removed @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud needs-triage This issue or PR still needs to be triaged. labels May 21, 2024
@pahud pahud self-assigned this May 21, 2024
This was referenced May 21, 2024
Merged
Closed
@mergify mergify bot closed this as completed in #30293 May 22, 2024
mergify bot pushed a commit that referenced this issue May 22, 2024
@pahud
feat(ec2): support placementGroup for ec2.Instance (#30293)
f4b1d5a 
### Issue # (if applicable)

Closes #30292

### Reason for this change

To allow ec2.Instance to specify `placementGroup`.

### Description of changes



### Description of how you validated changes

- [x] integ test
- [x] unit test


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced May 27, 2024
Closed
Closed
atanaspam pushed a commit to atanaspam/aws-cdk that referenced this issue Jun 3, 2024
@pahud @atanaspam
feat(ec2): support placementGroup for ec2.Instance (aws#30293)
b94b9f0 
### Issue # (if applicable)

Closes aws#30292

### Reason for this change

To allow ec2.Instance to specify `placementGroup`.

### Description of changes



### Description of how you validated changes

- [x] integ test
- [x] unit test


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this issue Jun 10, 2024
@pahud
feat(ec2): support placementGroup for ec2.Instance (aws#30293)
c6c5ff1 
### Issue # (if applicable)

Closes aws#30292

### Reason for this change

To allow ec2.Instance to specify `placementGroup`.

### Description of changes



### Description of how you validated changes

- [x] integ test
- [x] unit test


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@NOUIY NOUIY mentioned this issue Jun 14, 2024
Open
@snyk-io snyk-io bot mentioned this issue Jun 20, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 20, 2024
Open
@snyk-io snyk-io bot mentioned this issue Jun 21, 2024
Open
@rwlxxvii rwlxxvii mentioned this issue Jun 22, 2024
Merged
This was referenced Jun 22, 2024
Open
Open
This was referenced Jul 5, 2024
Open
Open
This was referenced Jul 16, 2024
Open
Open
@NOUIY NOUIY mentioned this issue Jul 23, 2024
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pahud pahud

Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@pahud @aws-cdk-automation