cli-lib-alpha: bootstrap with bad argument name for trust and trustForLookup

[juanenriqueescobar]

Describe the bug

trust and trustForLookup options are overwriting qualifier, so it's impossible to bootstrap a new account.

https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/cli-lib-alpha/lib/cli.ts#L187C1-L190

Expected Behavior

bootstrap a new account with custom options using cli-lib-alpha

Current Behavior

qualifier is defined as array and bootstrap fail with: failed bootstrapping: InvalidParameterType: Expected params.Parameters[6].ParameterValue to be a string

Reproduction Steps

 await cli.bootstrap({
    trust: '00000000000',
    trustForLookup: '11111111111111',
    qualifier: 'hnb659fds',
 })

trace show this:

"Parameters": [
        { "ParameterKey": "TrustedAccounts", "ParameterValue": "000000000," },
        { "ParameterKey": "TrustedAccountsForLookup", "ParameterValue": "" },
        {
            "ParameterKey": "CloudFormationExecutionPolicies",
            "ParameterValue": "arn:aws:iam::aws:policy/AdministratorAccess"
        },
        { "ParameterKey": "FileAssetsBucketName", "UsePreviousValue": true },
        { "ParameterKey": "FileAssetsBucketKmsKeyId", "UsePreviousValue": true },
        { "ParameterKey": "ContainerAssetsRepositoryName", "UsePreviousValue": true },
        { "ParameterKey": "Qualifier", "ParameterValue": ["hnb659fds", "0000000000000", "111111111111111"] },
        { "ParameterKey": "PublicAccessBlockConfiguration", "ParameterValue": "true" },
        { "ParameterKey": "InputPermissionsBoundary", "UsePreviousValue": true },
        { "ParameterKey": "UseExamplePermissionsBoundary", "UsePreviousValue": true },
        { "ParameterKey": "BootstrapVariant", "UsePreviousValue": true }
    ],

problem is in this line:

{ "ParameterKey": "Qualifier", "ParameterValue": ["hnb659fds", "0000000000000", "111111111111111"] },

Possible Solution

fix parameter names for

trust
https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/cli-lib-alpha/lib/cli.ts#L188

and trustForLookup
https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/cli-lib-alpha/lib/cli.ts#L189

Additional Information/Context

No response

CDK CLI Version

2.143.0

Framework Version

No response

Node.js Version

any

OS

any

Language

TypeScript

Language Version

No response

Other information

No response

[khushail]

Hi @juanenriqueescobar , thanks for reporting this. I am not able to repro the issue with the code . sharing the code which I tried-

import * as cdk from 'aws-cdk-lib';
import { Construct } from 'constructs';
import * as cli from '@aws-cdk/cli-lib-alpha';

export class ClialphaIssueStack extends cdk.Stack {
  constructor(scope: Construct, id: string, props?: cdk.StackProps) {
    super(scope, id, props);

    const ClialphaIssueStack = cli.AwsCdkCli.fromCdkAppDirectory("/Users/khushail/clialphaIssue");

     ClialphaIssueStack.bootstrap
    ({
      trust: '00000000000',
      trustForLookup: '11111111111111',
      qualifier: 'hnb659fds',
    });
  
  }
}

after running cdk synth --output "khushail/alialphaissue/cdk-app"
getting this error --

Error: Another CLI (PID=86992) is currently synthing to cdk.out. Invoke the CLI in sequence, or use '--output' to synth into different directories.

[khushail]

@juanenriqueescobar , although I see the qualifier in the code being overwritten, could you share some instructions to repro this?

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[juanenriqueescobar]

@khushail Hi!

I try to bootstrap my account, but get the error that I reported.

const cli = AwsCdkCli.fromCdkAppDirectory()
try {
    await cli.bootstrap({
        trust: '000000000000',
        trustForLookup: '000000000000',
    })
} catch (e) {
    process.exit(1)
}

I follow the source of cli-lib-alpha and there is an error in the arguments generation because they are overwriting the --qualifier option, I think that using the right parameters is enough to fix the problem.

[juanenriqueescobar]

the --qualifier param is almost a constant, It's used to create the bucket, roles, ecr repositories, etc, I am not trying to change it, but when I try to bootstrap the account, the cli-lib-alpha try to change it.

[khushail]

@juanenriqueescobar I agree with your point in saying that qualifier is being overwritten. I am not able to repro it , perhaps something missing on my side(working on it though).
For now, the issue is being marked as P2 which means it won't be immediately worked upon by the team but would need sometime. However if you would like to fix the issue and submit a PR, please feel free to do so. Thanks!

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.