Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2: support for specify IPv6 address count for an instance #31075

Closed
1 of 2 tasks
badmintoncryer opened this issue Aug 11, 2024 · 3 comments · Fixed by #31076 · 4 remaining pull requests
Closed
1 of 2 tasks

ec2: support for specify IPv6 address count for an instance #31075

badmintoncryer opened this issue Aug 11, 2024 · 3 comments · Fixed by #31076 · 4 remaining pull requests
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

Specify Ipv6AddressCount property for EC2 instance.

Use Case

We can not configure ipv6AddressCount property through EC2 instance L2 construct.

Proposed Solution

Add ipv6AddressCount to InstanceProps and pass it to CfnInstance.ipv6AddressCount property.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.150.0

Environment details (OS name and version, etc.)

irrelevant

@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 11, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Aug 11, 2024
@pahud
Copy link
Contributor

pahud commented Aug 12, 2024

Thank you for the PR @badmintoncryer !

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 12, 2024
@mergify mergify bot closed this as completed in #31076 Aug 28, 2024
@mergify mergify bot closed this as completed in e3e5e1c Aug 28, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
xazhao pushed a commit to xazhao/aws-cdk that referenced this issue Sep 12, 2024
### Issue # (if applicable)

Closes aws#31075.

### Reason for this change

AWS CDK cannot configure `ipv6AddressCount` property but cloudformation can do that.

### Description of changes

- Add `ipv6AddressCount` to `InstanceProps`
- Check whether `ipv6AddressCount` is a positive integer

### Description of how you validated changes

Add both unit and integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.